1697253 - `typeof VisualViewport` returns "function" regardless of the dom.visualviewport.enabled flag

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Masataka Yakura [:myakura]]

User Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.13; rv:87.0) Gecko/20100101 Firefox/87.0

Steps to reproduce:

1. open DevTools console
2. type typeof VisualViewport
3. check out the result

Actual results:

it returns "function"

Expected results:

it should return "undefined" on environments where dom.visualviewport.enabled is set to false (currently by default on desktop)

Comment 1

[Kagami Rosylight [:saschanaz] (they/them)]

Attachment: Bug 1697253 - Hide VisualViewport interface behind the existing pref

Bug 1357785 accidentally omitted the flag on the interface itself. This patch makes thing consistent to prevent potential confusion in feature detection.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e780bd8fa66a
Hide VisualViewport interface behind the existing pref r=edgar

Comment 3

[Dorel Luca [:dluca]]

Backed out changeset e780bd8fa66a (bug 1697253) for Mochitest failures in dom/base/test/test_domwindowutils.html. CLOSED TREE

Log:
https://treeherder.mozilla.org/logviewer?job_id=332764035&repo=autoland&lineNumber=4255

Push with failures:
https://treeherder.mozilla.org/jobs?repo=autoland&group_state=expanded&revision=e780bd8fa66ade0204a4dfe39034bfae411cb4a8

Backout:
https://hg.mozilla.org/integration/autoland/rev/2b451ba06562f5581e0ea9da0b3d9949abf558de

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/e055c9f7abe0
Hide VisualViewport interface behind the existing pref r=edgar

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/e055c9f7abe0