Closed
Bug 1697298
Opened 3 years ago
Closed 3 years ago
Have some error handling in ReadCompleteFile
Categories
(Core :: JavaScript Engine, task, P1)
Core
JavaScript Engine
Tracking
()
RESOLVED
FIXED
88 Branch
| Tracking | Status | |
|---|---|---|
| firefox88 | --- | fixed |
People
(Reporter: jorendorff, Assigned: jorendorff)
Details
Attachments
(1 file)
Today I discovered dist/bin/js -f ../ silently compiles and runs an empty script, because fopen(dirname, "rb") succeeds, returning a FILE that you can't read. Thanks so much, Unix!
While fixing that I noticed there was basically no error handling in here, so I added some.
|
Assignee | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
Assignee: nobody → jorendorff
Status: NEW → ASSIGNED
|
||
Updated•3 years ago
|
Severity: -- → N/A
Priority: -- → P1
Pushed by jorendorff@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/7251d2406edd Error handling in js::ReadCompleteFile. r=mgaudet
|
||
Comment 3•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox88:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in
before you can comment on or make changes to this bug.
Description
•