1697381 - Stop hardcoding the actor name in ContentSearch

Status: RESOLVED FIXED

(Firefox :: Search, task)

Description

[Hector Zhao [:hectorz]]

In the JSWindowActor conversion of ContentSearch, "ContentSearch" was hardcoded as the actor name in 1.

In China repack of desktop Fx, we're shipping a web-hosted fork of activity-stream 2 as our customized new tab, and subclasses of ContentSearchParent & ContentSearchChild are created in our extension to give the web page access to ContentSearch messages. 3

Since our forked page is loaded in normal web processes, once bug 1513680 landed, we had to monkey patch ContentSearch._reply 4 to keep it working.

I think passing the actual actor as part of the eventItem and _reply with it instead of using browser indirectly would eliminate the need for my monkey patch, and I'm hoping this is a minimal enough patch that you're open to take.

Thanks!

Comment 1

[Hector Zhao [:hectorz]]

Attachment: Bug 1697381 - Stop hardcoding the actor name in ContentSearch. r?adw

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/79d7d75d7308
Stop hardcoding the actor name in ContentSearch. r=adw

Comment 3

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/79d7d75d7308