1697467 - Non-native theme button/dropdown menu are not visible with high contrast

Status: VERIFIED FIXED

(Core :: Widget, defect)

Description

[Gabi Cheta [:Gabi] Desktop QA]

Attachment: test.html

Affected versions

• Nightly 88.0a1

Affected platforms

• Windows 10x64

Steps to reproduce

1. Launch Firefox Nightly
2. Enable high contrast mode (Alt+Shift+PtrScr)
3. Go to test.html link
4. Observe the button form control

Expected result

• Button form control is visible with high contrast mode

Actual result

• Button form control is not visible with high contrast

Regression range
Not a regression

Additional notes

• Button/dropdowns are visible when setting pref "widget.non-native-theme.enabled" = false
• https://www.groupon.com dropdown menus are not visible with high contrast

Comment 1

[Gabi Cheta [:Gabi] Desktop QA]

Attachment: Screenshot_2021-03-10 highcontrast.png

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1697467 - Push the high contrast code from nsNativeBasicThemeWin to nsNativeBasicTheme. r=mstange

Linux can also have high contrast (and mac, if you tweak prefs, but
let's assume that doesn't happen), so no reason we shouldn't share this
code.

One related simplification while I was doing this code move is that I
managed to remove the scrollbar "border" code. Turns out that Windows
was overriding ComputeScrollbarColors so that border and track colors
were always the same, and Linux was ignoring the border anyways, so with
this we can simplfiy the implementation a bit (as the Linux scrollbar
track / corner code can be shared with Windows now).

Comment 3

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1697467 - Don't use standins for non native theme when the document uses high contrast. r=mstange

As in that case we will actually use system colors.

Depends on D107863

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/483806cf81ce
Push the high contrast code from nsNativeBasicThemeWin to nsNativeBasicTheme. r=mstange
https://hg.mozilla.org/integration/autoland/rev/d465f635cd83
Don't use standins for non native theme when the document uses high contrast. r=mstange

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/f5231f80b867
Fix a typo, I don't know how to boolean.

Comment 6

[Sandor Molnar[:smolnar]]

https://hg.mozilla.org/mozilla-central/rev/483806cf81ce
https://hg.mozilla.org/mozilla-central/rev/d465f635cd83
https://hg.mozilla.org/mozilla-central/rev/f5231f80b867

Comment 7

[Gabi Cheta [:Gabi] Desktop QA]

Verified as fixed with Nightly 88.0a1 on Windows 10x64.