Closed Bug 1697486 Opened 3 years ago Closed 3 years ago

Update Protections Panel for Proton

Categories

(Firefox :: Protections UI, task, P2)

Product:
Firefox
Component:
Protections UI
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
firefox89 --- fixed

People

(Reporter: mconley, Assigned: prathiksha)

References

Details

(Keywords: helpwanted, Whiteboard: [proton-door-hangers][priority:2c])

Attachments

(2 files)

Bug 1697486 - Hide icons and remove header gradient in the protections panel when proton is enabled. r=mconley!
48 bytes, text/x-phabricator-request
Details | Review
Bug 1697486 - Update sizing of menu items and their hover, active and focus states when proton is enabled. r=mconley!
48 bytes, text/x-phabricator-request
Details | Review

We require the following changes when browser.proton.doorhangers.enabled is true:

  • The icons for the items at the bottom of the panel ("Protection Settings", "Protections Dashboard"), should be hidden
  • The menuitem sizing, hover and active states should match the other Proton-enabled panels (see the AppMenu for an example)
  • Remove the purple-ish gradient from the header of the panel
  • The "Manage Protection Settings" footer button should be styled like another menuitem. See the bottom of the History subview, for example.
Assignee: nobody → prathikshaprasadsuman
Status: NEW → ASSIGNED
Priority: P3 → P1
Priority: P1 → P2
Attachment #9210852 - Attachment description: Bug 1697486 - Update sizing of menu items and their hover and active states when proton is enabled. r=mconley! → Bug 1697486 - Update sizing of menu items and their hover, active and focus states when proton is enabled. r=mconley!
Whiteboard: [proton-door-hangers] → [proton-door-hangers][priority:2c]
Pushed by prathikshaprasadsuman@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/600254433833
Hide icons and remove header gradient in the protections panel when proton is enabled. r=mconley,desktop-theme-reviewers,harry
https://hg.mozilla.org/integration/autoland/rev/42aa58167200
Update sizing of menu items and their hover, active and focus states when proton is enabled. r=mconley,desktop-theme-reviewers,harry

https://hg.mozilla.org/mozilla-central/rev/600254433833
https://hg.mozilla.org/mozilla-central/rev/42aa58167200

Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox89: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
Regressions: 1703579
Depends on: 1703585
Regressions: 1703586
Depends on: 1703591
See Also: → 1703652
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: