1697526 - Add telemetry for when we extend the slice budget

Status: RESOLVED FIXED

(Core :: JavaScript: GC, task, P3)

Comment 1

[Jon Coppeard (:jonco)]

We also need to add telemetry for whether slices overran the budget.

Comment 2

[Jon Coppeard (:jonco)]

Attachment: Bug 1697526 - Add telemetry related to the GC budget r?sfink

This adds three measurements:

1. GC_BUDGET_WAS_INCREASED

   Whether the budget was increased due to taking to long or approaching the
   incremental limit.

2. GC_SLICE_WAS_LONG

   Whether a GC slice took 1.5 times or 5ms more than its budget.

3. GC_MINOR_WAS_LONG

   Whether a minor GC took more than 1ms.

Comment 3

[Jon Coppeard (:jonco)]

Attachment: data_collection_request.txt

Comment 4

[Jon Coppeard (:jonco)]

Attachment: data_collection_request.txt

Comment 5

[Chris H-C :chutten]

Comment on attachment 9242647 [details]
data_collection_request.txt

DATA COLLECTION REVIEW RESPONSE:

Is there or will there be documentation that describes the schema for the ultimate data set available publicly, complete and accurate?

Yes.

Is there a control mechanism that allows the user to turn the data collection on and off?

Yes. This collection is Telemetry so can be controlled through Firefox's Preferences.

If the request is for permanent data collection, is there someone who will monitor the data over time?

Yes, Jon Coppeard is responsible.

Using the category system of data types on the Mozilla wiki, what collection type of data do the requested measurements fall under?

Category 1, Technical.

Is the data collection request for default-on or default-off?

Default on for all channels.

Does the instrumentation include the addition of any new identifiers?

No.

Is the data collection covered by the existing Firefox privacy notice?

Yes.

Does the data collection use a third-party collection tool?

No.

---

Result: datareview+

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/00ec1254f44c
Add telemetry related to the GC budget r=sfink

Comment 7

[Cristian Tuns]

https://hg.mozilla.org/mozilla-central/rev/00ec1254f44c