Closed Bug 1697552 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27975 - [css-flexbox] Improve robustness of select-element-zero-height-* tests

Categories

(Core :: Layout: Flexbox, task, P4)

Product:
Core
Component:
Layout: Flexbox
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27975 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27975
Details from upstream follow.

b'Sergio Villar Senin <svillar@igalia.com>' wrote:

[css-flexbox] Improve robustness of select-element-zero-height-* tests

WebKit has been applying (since 2003) what it calls intrinsic margins to control elements (like menu lists) for several reasons, mainly to leave space for focus rings and to keep them from butting up against one another. Those intrinsic margins are applied only if the control element (like <select>) has auto or intrinsic size.

This is a problem in select-element-zero-height-* tests in which the control has auto size in the gold standard and a specified size (100%) in the reference. From the WebKit POV the former needs "intrinsic margins" while the latter don't, creating 2px differences in the results that has nothing to do with flexbox.

Component: web-platform-tests → Layout: Flexbox
Product: Testing → Core
Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/36daf55a8105
[wpt PR 27975] - [css-flexbox] Improve robustness of select-element-zero-height-* tests, a=testonly
Test result changes from PR not available.

https://hg.mozilla.org/mozilla-central/rev/36daf55a8105

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.