1697616 - PiP on video with unsupported mimetype shows a tiny window

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect, P5)

Description

[Tim Nguyen :ntim]

Attachment: image.png

Video: https://mozilla.modular.im/_matrix/media/r0/download/mozilla.org/bdc9df11898195c23a3a71ed605173083081fa5f (this is a .mov file)

See bottom left corner of screenshot.

Comment 1

[Micah [:mtigley] (she/her)]

Thanks for filing this Tim! As discussed earlier on Matrix it seems a bit odd the video controls are showing for you in this screenshot.

Just so I can better understand how the PiP window was opened, did you do this through the pip toggle button? Or the keyboard shortcut?

Comment 2

[Tim Nguyen :ntim]

(In reply to Micah Tigley [:mtigley] from comment #1)

Thanks for filing this Tim! As discussed earlier on Matrix it seems a bit odd the video controls are showing for you in this screenshot.

Just so I can better understand how the PiP window was opened, did you do this through the pip toggle button? Or the keyboard shortcut?

I toggled it through the PiP button. I can check if I have any prefs that may have affected this.

Comment 3

[Tim Nguyen :ntim]

Ah sorry, I just saw I had toggled media.videocontrols.picture-in-picture.video-toggle.always-show locally a while ago.

Comment 4

[Micah [:mtigley] (she/her)]

(In reply to Tim Nguyen :ntim from comment #3)

Ah sorry, I just saw I had toggled media.videocontrols.picture-in-picture.video-toggle.always-show locally a while ago.

Thanks! That did it :)

I discussed this with Swapnik over Matix earlier but wanted to reiterate it here for visibility. He proposed that we should hide the PiP toggle button if the source video has no video duration (or is just invalid) regardless of the pref setting. To do this, we might want to start looking at shouldShowPictureInPictureToggle and update the checks to include a valid video duration.

Comment 5

[Swapnik Katkoori]

Attachment: Bug 1697616 - Hide toggle when video duration is NaN. r=mtigley,mhowell

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/949a9ebf7fff
Hide toggle when video duration is NaN. r=mtigley,mhowell

Comment 7

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/949a9ebf7fff