Merge ClearOnShutdown with AppShutdown and generalize it to ProcessShutdown
Categories
(Core :: XPCOM, enhancement)
Tracking
()
People
(Reporter: jstutte, Unassigned)
References
Details
(Keywords: leave-open)
Attachments
(2 obsolete files)
This is a follow up from bug 1696397.
AppShutdown
and ClearOnShutdown
provide functions useful not only for the main process's shutdown. This bug proposes to:
- Generalize
AppShutdown
naming to becomeProcessShutdown
. This would include the renaming of some shutdown phases. - Merge the few functions of
ClearOnShutdown
withProcessShutdown
in order to share the same shutdown state variable. - Replace the static mapping of notification messages to shutdown phases with an initialization (yet to be defined) to be done by each process at startup time.
The overall goal would be to make shutdown phases something different and more fundamental for XPCOM than the associated notification messages, which should be a loose coupling for clients only.
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Comment 1•3 years ago
|
||
Updated•3 years ago
|
Reporter | ||
Comment 2•3 years ago
|
||
AppShutdown::AdvanceShutdownPhase
tried to preserved the original order we had historically in XPCOMShutdown
. This resulted in having called KillClearOnShutdown
before we tried fast shutdown and/or notified our observers.
It seems desirable to remove the objects associated via ClearOnShutdown(aPhase)
as last operation here, such that:
- fast shutdown can just override their (then useless) deletion
- otherwise notified observers can rely on them to still exist when executed
Depends on D145082
Comment 3•3 years ago
|
||
Comment on attachment 9274429 [details]
Bug 1697745: Part 1 - Remove obsolete ShutdownPhase::XPCOMShutdownLoaders. r?#xpcom-reviewers
Revision D145082 was moved to bug 1766572. Setting attachment 9274429 [details] to obsolete.
Comment 4•3 years ago
|
||
Comment on attachment 9274430 [details]
Bug 1697745: Part 2 - Run KillClearOnShutdown only after having notified observers in AdvanceShutdownPhase. r?#xpcom-reviewers
Revision D145083 was moved to bug 1766572. Setting attachment 9274430 [details] to obsolete.
Reporter | ||
Comment 5•3 years ago
|
||
Sorry for the attachment-noise here.
Once bug 1766572 landed we will have a better synchronization between the two phases, but the original scope of unifying AppShutdown
and ClearOnShutdown
remains valid.
Reporter | ||
Updated•3 years ago
|
Reporter | ||
Comment 6•2 years ago
|
||
(In reply to Jens Stutte [:jstutte] from comment #5)
Once bug 1766572 landed we will have a better synchronization between the two phases, but the original scope of unifying
AppShutdown
andClearOnShutdown
remains valid.
The scope remains valid, but I will not get to it very soon, thus unassigning for now.
Comment 7•2 years ago
|
||
The leave-open keyword is there and there is no activity for 6 months.
:nika, maybe it's time to close this bug?
For more information, please visit auto_nag documentation.
Comment 8•2 years ago
|
||
:jstutte do you still want to do something in this area, or can we close this bug out?
Reporter | ||
Comment 9•2 years ago
|
||
I definitely would want to find the time to do something on bug 1762840, and only after that look at this, so let's keep it for now.
Description
•