Remove tokio in audioipc code
Categories
(Core :: Audio/Video: cubeb, task, P3)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox113 | --- | fixed |
People
(Reporter: emilio, Assigned: kinetik)
References
(Blocks 2 open bugs)
Details
Attachments
(1 file)
It uses a very old tokio version that causes us to duplicate a lot of dependencies. Can we update it?
|
Assignee | |
Comment 1•3 years ago
|
||
|
Reporter | |
Comment 2•3 years ago
|
||
Even better, thank you!
|
|
Reporter | |
Comment 3•3 years ago
|
||
Matthew, any update here? tokio 0.1 is why we have a lot of old / dup dependencies.
|
|
Assignee | |
Comment 4•3 years ago
|
||
This is landing via bug 1726275 very soon.
|
|
Assignee | |
Comment 5•2 years ago
|
||
Bug 1726275 is about to land, but this also needs bug 1726279 before we can remove the old tokio 0.1 entirely. That should happen very early next year.
|
|
Assignee | |
Comment 6•2 years ago
|
||
|
||
Comment 7•2 years ago
|
||
Probably not a S2
Reminder, S2 means: (Serious) Major functionality/product severely impaired or a high impact issue and a satisfactory workaround does not exist
|
||
Updated•1 year ago
|
|
|
Assignee | |
Comment 8•1 year ago
|
||
AudioIPC v2 has been shipping in Windows for several cycles. Nightly macOS and Linux builds have had v2 enabled for a similar length of time (and will ride the trains in 113 via bug 1817043). macOS never shipped v1, so the backup plan in the event of major issues is to disable v2 and ship without cubeb sandboxing. This leaves Linux as the only platform shipping v1, but given the Nightly coverage it's extremely unlikely we'd need to revert Linux from v2 to v1. Given that, I think it's safe to remove AudioIPC v1 now rather than waiting for additional release cycles.
Pushed by mgregan@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/0dc7d445c194 Remove AudioIPC v1. r=glandium,supply-chain-reviewers,cubeb-reviewers,padenot
|
||
Comment 10•1 year ago
|
||
| bugherder | ||
Description
•