1697859 - Oauth window too small for authentication

Status: RESOLVED FIXED

(Thunderbird :: Instant Messaging, defect)

Description

[Richard Marti (:Paenglab)]

Attachment: oauth-window.png

Comment 1

[Richard Marti (:Paenglab)]

Only a side note, on bottom right of the window you see also multiple green circles. A

#security-button {
background-repeat: no-repeat;
}

would fix this. But it needs also more visually fixes and maybe a synchronization with the mail browserRequest.xhtml.

Comment 2

[Patrick Cloke [:clokep]]

Maybe we should just switch to using the mail stuff instead?

Comment 3

[Martin Giger [:freaktechnik]]

I'd be fine with using the mail browserRequest infrastructure. Is keeping the modules separate still a concern? Since there's no instantbird anymore I'm not so sure of that. Either way, I agree that we should take some major hints from the mail implementation that I ignored while getting the chat one to work again.

The mail browserRequest window has an "address bar", but no way to indicate the reason you're seeing the window. Is this still something we want, or maybe an UX dream of the past? (My UX dream would be a reworked account setup wizard that shows this inline, but we'd still have cases where we'd need to show a window to re-auth)

We can't directly use OAuth2.jsm either way, since we're not doing OAuth2, we're doing Matrix SSO.

Comment 4

[Patrick Cloke [:clokep]]

(In reply to Martin Giger [:freaktechnik] from comment #3)

Is keeping the modules separate still a concern? Since there's no instantbird anymore I'm not so sure of that. Either way, I agree that we should take some major hints from the mail implementation that I ignored while getting the chat one to work again.

I suspect it doesn't really matter anymore if we use things from mailnews. There might already be a couple of instances of this TBH.

We can't directly use OAuth2.jsm either way, since we're not doing OAuth2, we're doing Matrix SSO.

Right, I was referring to the browserRequest stuff. :)

Comment 5

[Martin Giger [:freaktechnik]]

Attachment: with-mail-browser-request.png

This is a quick experiment to use the window (and layout) from mail. The one improvement I'd suggest is to add the account name to the title, so it's clear what account you're supposed to log in for. Assuming the title of the window is visible on all platforms.

Comment 6

[Patrick Cloke [:clokep]]

The one improvement I'd suggest is to add the account name to the title, so it's clear what account you're supposed to log in for.

This sounds like it would be an improvement for mail accounts too, if that info is available.

Overall, I think that window looks much nicer!

Comment 7

[Magnus Melin [:mkmelin]]

Didn't look at the code, but usually there's the login_hint parameter passed, which makes which account pretty clear.

Comment 8

[Martin Giger [:freaktechnik]]

Yeah, this was just me re-using the string that we already use in the chat version of the window which had a separate label for the account name info.

Comment 9

[Martin Giger [:freaktechnik]]

Attachment: Bug 1697859 - Improve chat browser auth window. r=clokep

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/4ee54b7ab251
Improve chat browser auth window. r=clokep

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/c3a8bea8a7f8
followup - fix black linting. rs=black DONTBUILD