169790 - CERT_DecodeDERCrlEx should be named CERT_DecodeDERCrlWithFlags

Status: RESOLVED FIXED

(NSS :: Libraries, defect, P1)

Description

[Nelson Bolyard (seldom reads bugmail)]

This bug is the result of a review of functions being newly exported in 
NSS 3.6 that Wan-Teh asked me to perform.

CERT_DecodeDERCrlEx is a new function being exported in NSS 3.6.  
I really dislike the Ex suffix.  It's a Microsoft-ism, IMO.  It tells the 
reader that we didn't think hard enough about the function in the first 
place and had to extend it, but it doesn't give any clue about what the 
extension is.  I don't think any other exported NSS functions end with Ex.  
I prefer something like "WithFlags", which explains what the addition to 
the API is.

We should fix this for NSS 3.6, or not at all.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

Marking P1 for 3.6 per Wan-Teh's instructions.

Comment 2

[Wan-Teh Chang]

Attachment: Proposed patch

Comment 3

[Wan-Teh Chang]

Fix checked in.

There is one exported NSS function with the "Ex" suffix:
SECMOD_AddNewModuleEx.  All the other extended variants
of NSS functions use the "WithFlags" suffix, so I agree
with this change, which correctly describes the difference
between CERT_DecodeDERCrl and the new function.