1697991 - The crash reporter window should support Dark Mode on macOS

Status: RESOLVED FIXED

(Toolkit :: Crash Reporting, enhancement)

Description

[Markus Stange [:mstange]]

Attachment: crash reporter looking good

We currently have NSRequiresAquaSystemAppearance set to true in the crash reporter's Info.plist (from bug 1578917). This means that the crash reporter window will render in Light Mode even when the system is set to Dark Mode.

We can set the value to false, and the crash reporter will correctly adapt to Dark Mode. There's only one bug: When clicking the Details button, the text box with the raw data has black-on-black text. So we should fix that bug and then flip the switch.

Comment 1

[Markus Stange [:mstange]]

Attachment: crash reporter looking not so good

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1697991 - Enable Dark Mode support in the crash reporter client, and fix a case of black-on-black text. r=#mac-reviewers

Depends on D108150

Comment 3

[Markus Stange [:mstange]]

Attachment: screenshot with fix

Comment 4

[Markus Stange [:mstange]]

Testing this was quite tricky. To work around bug 1698163, I had to copy libnss3.dylib and libmozglue.dylib from ../obj-m-opt/dist/bin/ to ../obj-m-opt/dist/Nightly.app/Contents/MacOS/crashreporter.app/Contents/MacOS/. And the crash reporter deletes the .dmp and .extra files every time it runs, so I had to copy those before each test. I got them from the artifacts of this build: https://treeherder.mozilla.org/logviewer?job_id=329542444&repo=mozilla-beta&lineNumber=112341 and saved them at ~/Downloads/dmp-from-try/.
And ./mach build binaries doesn't update the crashreporter binary in the crashreporter.app bundle, so I had to copy that too.
So I ended up doing:

% ./mach build binaries && \
cp ../obj-m-opt/dist/bin/crashreporter ../obj-m-opt/dist/Nightly.app/Contents/MacOS/crashreporter.app/Contents/MacOS/crashreporter && \
cp ~/Downloads/dmp-from-try/* ~/Downloads/ && \
../obj-m-opt/dist/Nightly.app/Contents/MacOS/crashreporter.app/Contents/MacOS/crashreporter /Users/mstange/Downloads/75689641-5D2B-4E22-92FF-EFC488C457FC.dmp

Comment 5

[Markus Stange [:mstange]]

Never mind the previous comment; I could just have done the following:

% ./mach build && ./mach run -P debug --enable-crash-reporter

and used about:crashparent.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6192dbe6a3fd
Enable Dark Mode support in the crash reporter client, and fix a case of black-on-black text. r=mac-reviewers,bradwerth

Comment 7

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6192dbe6a3fd