1698193 - Skip failing Fission TSan mochitest-plain tests and enable test-linux1804-64-tsan/opt-mochitest-plain-fis-e10s

Status: RESOLVED FIXED

(Testing :: Mochitest, defect, P2)

Description

[Chris Peterson [:cpeterson]]

ahal tried to enable mochitest-plain for Fission on linux1804-64-tsan/opt in bug 1694833. Unfortunately, there are some new TSan test failures with Fission. mochitest-plain already runs on linux1804-64-tsan/opt for e10s (non-Fission), so Fission is presumably causing these new failures.

Try run:

https://treeherder.mozilla.org/jobs?repo=try&revision=c50dd851c95cc3b8d0cd1e6cd4889b6a6a4d842a&searchStr=tsan&group_state=expanded

13 possible regressions (and 17 known issues):

https://treeherder.mozilla.org/push-health/push?repo=try&revision=c50dd851c95cc3b8d0cd1e6cd4889b6a6a4d842a

• dom/filesystem/compat/tests/test_basic.html = bug 1698686
• dom/svg/test/test_SVGLengthList.xhtml = bug 1698687
• dom/tests/mochitest/storageevent/test_storageLocalStorageEventCheckNoPropagation.html = bug 1698688
• dom/url/tests/test_url.html = bug 1698689
• toolkit/components/alerts/test/test_alerts.html = bug 1698690

Comment 1

[Chris Peterson [:cpeterson]]

These are probably test races.

I will file new bugs for each test that had a new TSan failure. Those bugs probably won't need to block Fission MVP because their failures are not TSan errors.

We should use this bug to skip those tests so we can enable TSan for the mochitest-plain tests that do pass with Fission.

Comment 2

[Chris Peterson [:cpeterson]]

Assigning remaining "Enable Fission tests on more platforms" bugs to ahal.

Comment 3

[Andrew Halberstadt [:ahal]]

Attachment: Bug 1698193 - [ci] Enable mochitest-plain-fis with linux64 tsan

This patch adds the following tasks to both autoland and central:

test-linux1804-64-tsan/opt-mochitest-plain-fis-e10s

Note this has 20+ chunks so is not insignificant.

Comment 4

[Chris Peterson [:cpeterson]]

Andrew, I think we can enable these Fission TSan tests now without adding new skip-if annotations for the blocking bugs.

I re-triggered these Fission TSan tests on try 8 times: 3 times with new skip-if annotations for test failures in the blocking bugs and 5 times without new annotations:

https://treeherder.mozilla.org/jobs?repo=try&revision=e151fb36d68f03b17cce5fc56a70c7648f338bb6

https://treeherder.mozilla.org/jobs?repo=try&revision=c82229b1557dd1c6251989f2064571b337c5b022

There was only one failure and it looks like a duplicate of RESOLVED INCOMPLETE bug 1627172. I'll close the blocking bugs as WORKSFORME, but I'll hold on to my new skip-if patch in case we do need it.

Comment 5

[Andrew Halberstadt [:ahal]]

Cool, I'll put it up for review.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/a38a75e4ad26
[ci] Enable mochitest-plain-fis with linux64 tsan r=jmaher

Comment 7

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/a38a75e4ad26