169827 - [typeaheadfind] After typing >3 not found characters, can't typeaheadfind again

Status: VERIFIED FIXED

(SeaMonkey :: Find In Page, defect)

Description

[Tuukka Tolvanen (sp3000)]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20020918
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.2b) Gecko/20020918

.

Reproducible: Always

Steps to Reproduce:
1. Type enough characters to trigger the quickly mashed chars fix of bug 166993
2. Hit esc
3. Type some more characters

Actual Results:  
2. Esc does not delete the found-highlight (if any);
3. Typeaheadfind doesn't happen

Expected Results:  
2. Esc should reset the bad state and deselect the matched-highlight;
3. Typeaheadfind should happen

Scrolling will cause the typeaheadfind-highlight to turn into a regular
selection, and then typeaheadfind will work again.

Comment 1

[Tuukka Tolvanen (sp3000)]

(ctrl-G / F3 will also unclog it)

Comment 2

[Ashley Bischoff (blog at handcoding.com)]

Confirming and marking NEW (2002092108 on Win2k).

OS -> All

Comment 3

[sairuh (rarely reading bugmail)]

actually, after using type ahead find (on three platforms: win2k, linux and mac
os x, today's moz trunk build), this is prolly the most frequent issue i
encounter. true, it could be my own typing habits, but it's an annoying impediment.

nominating for buffy.

aaron, when you're next in the office, perhaps you could come over and watch me
when i run into this. perhaps we could narrow down the issue, if it'd help
resolve it. :)

Comment 4

[Tuukka Tolvanen (sp3000)]

fwiw, moving the check for esc key up before the key-mashing condition
(mBadKeysSinceMatch >= kMaxBadCharsBeforeCancel) check fixes this

Comment 5

[Aaron Leventhal]

Yeah, that should be the right fix. I want to check in bug 167921 first before I
make a patch.

Comment 6

[Tuukka Tolvanen (sp3000)]

I suspected as much ;)

Comment 7

[Aaron Leventhal]

Attachment: Does key mashing check after check for VK_ESCAPE

Seeking r=

Comment 8

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 100475 [details] [diff] [review]
Does key mashing check after check for VK_ESCAPE

Makes sense.  r=caillon.

Comment 9

[Aaron Leventhal]

seeking sr=alecf

Comment 10

[Alec Flett]

Comment on attachment 100475 [details] [diff] [review]
Does key mashing check after check for VK_ESCAPE

sr=alecf

Comment 11

[sairuh (rarely reading bugmail)]

forgot to add: F3 didn't help (on win2k or linux) to unclog this, but accel-G
did (all platforms).

Comment 12

[Aaron Leventhal]

checked in

Comment 13

[sairuh (rarely reading bugmail)]

aah, much better. :) looks fixed using 2002.09.26.04 mozilla trunk bits.

after i type several junk chars, i get "Type ahead find stopped." however, i'm
no longer in the clogged state: i can hit backspace (delete on mac) and i can
continue adding chars to the non-junk portion of the string. i can also cancel
my previous non-junk string and start over. don't have to hit accel-G at all
--it's a lot more smooth. thanks!

Comment 14

[Aaron Leventhal]

You're welcome - always happy to help unclog someone.

Comment 15

[Anthony DeRobertis]

*** Bug 171164 has been marked as a duplicate of this bug. ***