1698284 - Minor non-native-theme high-contrast fixes.

Status: RESOLVED FIXED

(Core :: Widget, defect)

Comment 1

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1698284 - Minor high-contrast theme tweaks in the non-native theme. r=mstange

Mostly use matching foreground / background colors. Buttonface is the
counterpart of Buttontext, and Highlightext the counterpart of Highlight.

This fixes contrast of checkboxes and radio buttons for example, and a couple
other contrast issues with light themes specially.

Comment 2

[Emilio Cobos Álvarez (:emilio)]

Attachment: Bug 1698284 - Make the non-native theme not use system colors if we're not overriding the pages' colors. r=morgan

This prevents contrast issues with high contrast themes when the page only
specifies some of the colors (which is an issue which we have historically
had on GTK with dark themes for a long time).

Feel free to push back on this if you prefer this, as on GTK we force a light
theme on content anyways, but this is a problem on windows for users that use a
high contrast theme but allow pages to override colors.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8a4decf8dc29
Minor high-contrast theme tweaks in the non-native theme. r=mstange

Comment 4

[Narcis Beleuzu [:NarcisB]]

https://hg.mozilla.org/mozilla-central/rev/8a4decf8dc29

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/400864685abc
Make the non-native theme not use system colors if we're not overriding the pages' colors. r=morgan

Comment 6

[Alexandru Michis [:malexandru]]

https://hg.mozilla.org/mozilla-central/rev/400864685abc