Closed Bug 1698327 Opened 5 years ago Closed 4 years ago

comm/mail/test/browser/content-tabs/browser_contentTab.js test fails, Unknown Collection "thunderbird/url-classifier-skip-urls

Categories

(Thunderbird :: Build Config, defect)

Product:
Thunderbird
Component:
Build Config
Type:
defect

Tracking

(thunderbird_esr78 unaffected)

Status:
RESOLVED FIXED
Milestone:
89 Branch
Tracking Flags:
Tracking Status
thunderbird_esr78 --- unaffected

People

(Reporter: ishikawa, Assigned: mkmelin)

Details

Attachments

(1 file)

Bug 1698327 - ship (empty) url-classifier-skip-urls.json remote setting to prevent pointless errors in console. r=sancus
48 bytes, text/x-phabricator-request
Details | Review

The said test fails on try-comm-central due to timeout.
I found the following error messages in the log.

Not sure if this is the reason for timeout, but these need to be fixed first.

[task 2021-03-13T04:11:40.135Z] 04:11:40     INFO - waitFor@resource://testing-common/mozmill/utils.jsm:111:12
[task 2021-03-13T04:11:40.135Z] 04:11:40     INFO - wait_for_content_tab_load@resource://testing-common/mozmill/ContentTabHelpers.jsm:274:9
[task 2021-03-13T04:11:40.135Z] 04:11:40     INFO - open_content_tab_with_url@resource://testing-common/mozmill/ContentTabHelpers.jsm:185:28
[task 2021-03-13T04:11:40.136Z] 04:11:40     INFO - test_content_tab_open@chrome://mochitests/content/browser/comm/mail/test/browser/content-tabs/browser_contentTab.js:48:38
[task 2021-03-13T04:11:40.136Z] 04:11:40     INFO - Tester_execTest/<@chrome://mochikit/content/browser-test.js:1089:34
[task 2021-03-13T04:11:40.136Z] 04:11:40     INFO - Tester_execTest@chrome://mochikit/content/browser-test.js:1129:11
[task 2021-03-13T04:11:40.136Z] 04:11:40     INFO - nextTest/<@chrome://mochikit/content/browser-test.js:949:14
[task 2021-03-13T04:11:40.136Z] 04:11:40     INFO - SimpleTest.waitForFocus/waitForFocusInner/focusedOrLoaded/<@chrome://mochikit/content/tests/SimpleTest/SimpleTest.js:1037:23
[task 2021-03-13T04:11:40.136Z] 04:11:40     INFO - 
[task 2021-03-13T04:11:40.136Z] 04:11:40     INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://mochi.test:8888/browser/comm/mail/test/browser/content-tabs/html/whatsnew.html" line: 0}]
[task 2021-03-13T04:11:40.136Z] 04:11:40     INFO - TEST-PASS | comm/mail/test/browser/content-tabs/browser_contentTab.js | "What's New Content Test" == "What's New Content Test" - 
[task 2021-03-13T04:11:40.136Z] 04:11:40     INFO - Leaving test bound test_content_tab_open
[task 2021-03-13T04:11:40.136Z] 04:11:40     INFO - Entering test bound test_spellcheck_in_content_tabs
[task 2021-03-13T04:11:40.136Z] 04:11:40     INFO - Buffered messages logged at 04:10:56
[task 2021-03-13T04:11:40.136Z] 04:11:40     INFO - TEST-PASS | comm/mail/test/browser/content-tabs/browser_contentTab.js | true == true - 
[task 2021-03-13T04:11:40.136Z] 04:11:40     INFO - TEST-PASS | comm/mail/test/browser/content-tabs/browser_contentTab.js | true == true - 
[task 2021-03-13T04:11:40.136Z] 04:11:40     INFO - TEST-PASS | comm/mail/test/browser/content-tabs/browser_contentTab.js | true == true - 
[task 2021-03-13T04:11:40.136Z] 04:11:40     INFO - TEST-PASS | comm/mail/test/browser/content-tabs/browser_contentTab.js | true == true - 
[task 2021-03-13T04:11:40.139Z] 04:11:40     INFO - TEST-PASS | comm/mail/test/browser/content-tabs/browser_contentTab.js | true == true - 
[task 2021-03-13T04:11:40.139Z] 04:11:40     INFO - TEST-PASS | comm/mail/test/browser/content-tabs/browser_contentTab.js | What, is zombocom a registered word now? - true == true - 
[task 2021-03-13T04:11:40.139Z] 04:11:40     INFO - TEST-PASS | comm/mail/test/browser/content-tabs/browser_contentTab.js | But I just taught you this word! - true == true - 
[task 2021-03-13T04:11:40.140Z] 04:11:40     INFO - Leaving test bound test_spellcheck_in_content_tabs
[task 2021-03-13T04:11:40.140Z] 04:11:40     INFO - Entering test bound test_content_tab_default_favicon
[task 2021-03-13T04:11:40.141Z] 04:11:40     INFO - Buffered messages logged at 04:10:57
[task 2021-03-13T04:11:40.141Z] 04:11:40     INFO - TEST-PASS | comm/mail/test/browser/content-tabs/browser_contentTab.js | [object Object] == [object Object] - 
[task 2021-03-13T04:11:40.141Z] 04:11:40     INFO - Console message: [JavaScript Error: "The character encoding of the HTML document was not declared. The document will render with garbled text in some browser configurations if the document contains characters from outside the US-ASCII range. The character encoding of the page must be declared in the document or in the transfer protocol." {file: "http://mochi.test:8888/browser/comm/mail/test/browser/content-tabs/html/whatsnew1.html" line: 0}]
[task 2021-03-13T04:11:40.143Z] 04:11:40     INFO - TEST-PASS | comm/mail/test/browser/content-tabs/browser_contentTab.js | "What's New Content Test 1" == "What's New Content Test 1" - 
[task 2021-03-13T04:11:40.144Z] 04:11:40     INFO - TEST-PASS | comm/mail/test/browser/content-tabs/browser_contentTab.js | Checking tab favicon - "http://mochi.test:8888/favicon.ico" == "http://mochi.test:8888/favicon.ico" - 
[task 2021-03-13T04:11:40.144Z] 04:11:40     INFO - Leaving test bound test_content_tab_default_favicon
[task 2021-03-13T04:11:40.145Z] 04:11:40     INFO - Entering test bound test_content_tab_onbeforeunload
[task 2021-03-13T04:11:40.145Z] 04:11:40     INFO - Console message: [JavaScript Error: "Failed to get strings from dom.properties" {file: "resource:///modules/PromptCollection.jsm" line: 33}]
[task 2021-03-13T04:11:40.145Z] 04:11:40     INFO - asyncBeforeUnloadCheck@resource:///modules/PromptCollection.jsm:33:10
[task 2021-03-13T04:11:40.145Z] 04:11:40     INFO - permitUnload@chrome://global/content/elements/browser-custom-element.js:1709:21
[task 2021-03-13T04:11:40.145Z] 04:11:40     INFO - tryCloseTab@chrome://messenger/content/specialTabs.js:962:27
[task 2021-03-13T04:11:40.145Z] 04:11:40     INFO - closeTab@chrome://messenger/content/tabmail.js:1170:41
[task 2021-03-13T04:11:40.145Z] 04:11:40     INFO - test_content_tab_onbeforeunload@chrome://mochitests/content/browser/comm/mail/test/browser/content-tabs/browser_contentTab.js:177:14
[task 2021-03-13T04:11:40.145Z] 04:11:40     INFO - 
[task 2021-03-13T04:11:40.146Z] 04:11:40     INFO - Buffered messages finished
[task 2021-03-13T04:11:40.146Z] 04:11:40     INFO - TEST-UNEXPECTED-FAIL | comm/mail/test/browser/content-tabs/browser_contentTab.js | Test timed out -

Bug 1601484
Bug 1680871 may be related.

Component: Untriaged → Build Config

The test isn't failing, but we should fix it not to get the console spew

Assignee: nobody → mkmelin+mozilla
Status: NEW → ASSIGNED
status-thunderbird_esr78: --- → unaffected

(In reply to Magnus Melin [:mkmelin] from comment #1)

The test isn't failing, but we should fix it not to get the console spew

Are you sure the test isn't failing?
The last line I copied said

TEST-UNEXPECTED-FAIL | comm/mail/test/browser/content-tabs/browser_contentTab.js | Test timed out -

Maybe I am looking at the wrong output of a different test, then.
Sometimes test output are interspersed and difficult to interpret.

It failed in whatever run you were doing, but it doesn't fail locally and it's not failing on treeherder. So essentially "not failing",

(In reply to Magnus Melin [:mkmelin] from comment #3)

It failed in whatever run you were doing, but it doesn't fail locally and it's not failing on treeherder. So essentially "not failing",

I see. I wonder what patch was related to this failure.
I will figure it out.

To shut up the error I think we need to put the file onto our server as well.

File copied from services/settings/dumps/main/url-classifier-skip-urls.json

I assume this is supposed to be on the thunderbird-settings server, but in what bucket etc? What's the comparable Firefox URL?

This is on the server: https://thunderbird-settings.thunderbird.net/v1/buckets/thunderbird/collections/url-classifier-skip-urls

In the future it'd be helpful to get the actual JSON schema for these collections... I think that requires someone who can login on their Kinto instance and retrieve it. I couldn't find a public source for that one anywhere.

I made a guess at it based on old data, using a schema generator, and I don't think it matters as long as we're just leaving the object empty, but still.

Pushed by mkmelin@iki.fi:
https://hg.mozilla.org/comm-central/rev/ab37715f5ae1
ship (empty) url-classifier-skip-urls.json remote setting to prevent pointless errors in console. r=sancus

Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 89 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: