Open Bug 1698469 Opened 3 years ago Updated 3 years ago

Consider changing meter suboptimum value to have Mark system color background in hcm appearance:auto

Categories

(Core :: Widget, enhancement, P3)

All
Unspecified
enhancement

Tracking

()

People

(Reporter: aja, Unassigned)

References

(Blocks 1 open bug)

Details

Followup to bug 1698336.
Would give better semantics for sub-optimum value of meter element.
Optimum value already set to Highlight system color.

Flags: needinfo?(emilio)
See Also: → 1698336
See Also: → 1638052

This could get some input from Morgan / other a11y folks :)

Blocks: hcm
Severity: -- → S3
Depends on: 1638052
Flags: needinfo?(emilio)
Priority: -- → P3
See Also: 1638052

Is the goal here to differentiate between optimum and sub-optimum in HCM (since currently they're both highlight color?)
That sounds like a good idea to me. Is there a particular property of mark color that makes you inclined to use it for this (or do we already adjust this color somehow for HCM?)

Flags: needinfo?(william.f.goldstein2)

Yes, to differentiate between optimum and sub-optimum.
There's an example in spec showing Mark as Yellow, and MarkText as black...but they are system colors, so can vary per OS/theme settings.
In the case where an OS doesn't supply a color, I'd suggest fallback to something more like orange,
which would probably have better visibility in light HCM themes.

Flags: needinfo?(william.f.goldstein2)

(In reply to Bill Goldstein [:aja] (UTC-6) from comment #3)

Yes, to differentiate between optimum and sub-optimum.
There's an example in spec showing Mark as Yellow, and MarkText as black...but they are system colors, so can vary per OS/theme settings.
In the case where an OS doesn't supply a color, I'd suggest fallback to something more like orange,
which would probably have better visibility in light HCM themes.

Great! I think that's the right thing to do, thanks for the explanation! :) In terms of a fall-back, it might make more sense to use a value that /is/ specified by the client, given some users use HCM customization for other reasons, ie. to generate photo-sensitive themes, that we may disrupt with a static choice. Also, if we pick a fixed color we run the risk of having the user select the same thing for their foreground/background, which might make this component inaccessible

You need to log in before you can comment on or make changes to this bug.