Closed
Bug 1698492
Opened 3 years ago
Closed 3 years ago
FxA Sync Now string is not updated accordingly while syncing
Categories
(Firefox :: Menus, defect)
Tracking
()
VERIFIED
FIXED
88 Branch
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox86 | --- | disabled |
| firefox87 | --- | disabled |
| firefox88 | --- | verified |
People
(Reporter: ailea, Assigned: emmamalysz)
References
(Blocks 2 open bugs, Regression)
Details
(Keywords: regression, Whiteboard: [proton-hamburger-menu])
Attachments
(2 files)
Tested with:
Nightly 88.0a1 (2021-03-15)
Tested on:
Windows 10
Preconditions:
In about:config, set browser.proton.enabled = true
Steps:
- Launch Firefox Nightly and sign in to sync.
- Focus out the browser for 1-2 minutes.
- Open the FxA submenu.
Actual result:
The sync blue icon is displayed and rotates but the string is still "Sync Now" while syncing. (See the screen recording attached in comment 1).
Expected result:
Based on the documentation and on the comment.1 from bug 1694678, when syncing is in progress the string should be "Syncing...". When the string is "Sync Now" the blue sync icon should not be displayed.
This seems to be regressed by: https://bugzilla.mozilla.org/show_bug.cgi?id=1694678
@Emma, could you please take a look over this when you get a chance?
Flags: needinfo?(emalysz)
|
Reporter | |
Updated•3 years ago
|
Severity: -- → S3
|
||
Updated•3 years ago
|
Keywords: regression
|
|
Reporter | |
Comment 1•3 years ago
|
||
|
||
Updated•3 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-549
|
||
Updated•3 years ago
|
See Also: → https://jira.mozilla.com/browse/FIDEFE-562
|
|
||
Updated•3 years ago
|
See Also: https://jira.mozilla.com/browse/FIDEFE-562 →
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
Assignee | |
Updated•3 years ago
|
Assignee: nobody → emalysz
Status: NEW → ASSIGNED
Flags: needinfo?(emalysz)
|
||
Updated•3 years ago
|
Attachment #9209254 -
Attachment description: Bug 1698492, synchronously update fxa sync now string to avoid timing errors → Bug 1698492, dynamically set data-l10n-id attribute for sync now buttons when panel views are showing
Pushed by emalysz@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/089aa761f9f7 dynamically set data-l10n-id attribute for sync now buttons when panel views are showing r=Gijs,fluent-reviewers
|
||
Comment 4•3 years ago
|
||
| bugherder | ||
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
|
||
Updated•3 years ago
|
status-firefox-esr78:
--- → unaffected
|
||
Updated•3 years ago
|
Flags: qe-verify+
|
|
Reporter | |
Comment 5•3 years ago
|
||
Verified - Fixed in Beta 88.0b4 and latest Nightly 89.0a1 (2021-03-28), using Windows 10, Ubuntu 18.04 and MacOS 10.15.
|
||
Updated•3 years ago
|
Has Regression Range: --- → yes
You need to log in
before you can comment on or make changes to this bug.
Description
•