1698514 - Multiple quit/close warnings appear when closing/quitting multiple times without responding to the first dialog

Status: RESOLVED DUPLICATE of bug 1706963

(Firefox :: Tabbed Browser, defect, P3)

Description

[Alice0775 White]

Steps to reproduce:

1. Enable Titlebar
2. Open multiple tabs(more than 3 tabs)
3. Click native window close button multiple times
4. Click "Close" button in the alert box
   --- the alert box will appear again and again --- Bug!
   (Optionally)
5. Click "Cancel" button in the alert box (and repeats step 5 if any)
   --- If you choose "Close" even once, the browser will close even if you choose "Cancel" for all the rest. --- Maybe bug!

Actual results:
The native window close button is clickable multiple times.
The alert box appears multiple times.

Expected results:
The native window's close button should not be clickable multiple times.
There should be only one alert box.

Comment 1

[Alice0775 White]

There are 2 regression window.
#1:
The native window close button is clickable multiple times.
The alert box sometimes disappears.
Browser sometimes dimmed without the alert box.
This bug also appear when choose "Close Window" from right click taskbar button.

#2:
The native window close button is clickable multiple times.
This bug also appear when choose "Close Window" from right click taskbar button.

#1 regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=9cf59af57183940e3d5f629f4ea29b499e956fca&tochange=1129347e2aadcde6d60e03b6917539413c306639

Regressed by Bug 1685313

#2 regression window:
https://hg.mozilla.org/integration/autoland/pushloghtml?fromchange=50cd37e08dd9ba6cfe4aec7e6b1f208400a76d9e&tochange=f476c97b7c04306d7e21305a06de61b6d718714c

Bug 1696793 does not fix multiple aleart box problem.

Comment 3

[:Gijs (he/him)]

This should be fixable by teaching the _onQuitRequest handling code in BrowserGlue.jsm and its warnAboutClosingWindow sibling in browser.js to both track in some way whether they have already been invoked (clearing that flag when the dialog returns in a finally clause or similar), and if so, when re-entering, bail immediately (and indicate not wanting to close). In the quit case in BrowserGlue, we'd want to track the browser window in which we show the dialog and (re-)raise it via window.focus() if quitting is attempted a second time. See also bug 1524249 for the quit steps on macOS which predate this issue (which should be the _onQuitRequest case, too).

Comment 5

[Jody Heavener]

Attachment: Screen Recording 2021-05-25 at 9.44.28 AM.mov

The issue of multiple alert boxes no longer occurs for me in Nightly 90.0a1 (2021-05-25). Video demonstrates that attempting to close multi-tab window via click and keyboard shortcut both only result in one confirmation dialog.

Comment 6

[:Gijs (he/him)]

Ed, did this get fixed by the work to make this warning override the onboarding modal, ie bug 1706963?

Comment 7

[Ed Lee :Mardak]

As the bug is titled, yes this is fixed with bug 1706963 as multiple subsequent prompts don't appear after interacting with the first. The earlier/current prompts get closed similar to the user selecting Cancel to then show the next (potentially same) quit/close prompt.