Closed Bug 169853 Opened 22 years ago Closed 22 years ago

review: Templatise all calls to DisplayError, Patch v.1

Categories

(Bugzilla :: Bugzilla-General, defect)

2.10
Other
Other
defect
Not set
normal

Tracking

()

CLOSED FIXED
Bugzilla old

People

(Reporter: gerv, Assigned: burnus)

References

()

Details

Gervase Markham <gerv@mozilla.org> has requested review for bug #163114: Templatise all calls to DisplayError, attachment #99951 [details] [diff] [review]: Patch v.1. http://bugzilla.mozilla.org/attachment.cgi?id=99951&action=edit Additional Comments from Requester: Another patch on the path to full localisability :-) Gerv
+ [% ELSIF error == "mismatched_bug_ids_on_obsolete" %] + Attachment [% attach_id FILTER html %] ([% description %]) is attached + to bug [% attach_bug_id %], but you tried to flag it as obsolete while + creating a new attachment to bug [% my_bug_id %]. Has it any reason that attach_bug_id is FILTER html, but description is not? Same here: + [% ELSIF error == "attachment_already_obsolete" %] + Attachment #[% attachid %] ([% description %]) is already obsolete. Additionally I cannot find anything regarding this + # Assign the bug to the user, if they are allowed to take it + if ($::FORM{'takebug'} && UserInGroup("editbugs")) { + SendSQL("UPDATE bugs SET assigned_to = $vars->{'user'}{'userid'}, + bug_status = 'ASSIGNED', resolution = '' + WHERE bug_id = $::FORM{'bugid'}"); + } + in the templates. Is this related to a different bug and only half diffed? Otherwise it looks ok: r=burnus
Version: 2.10
[Usual practice is to put the review comments in the original bug, not the review bug.] That extra code is a mistake; something I forgot to remove. All those things need to be FILTERed, I just forgot. I'll fix this up and check it in. Gerv
Status: NEW → RESOLVED
Closed: 22 years ago
Resolution: --- → FIXED
in the process of eliminating the Review component (this is spam #1 of 2) for the filters: "torgus borgus"
Status: RESOLVED → VERIFIED
Eliminating the Review component from the Bugzilla product. (spam #2 of 2) for the filters: "torgus borgus"
Status: VERIFIED → CLOSED
Component: Reviews → Bugzilla-General
Target Milestone: --- → Bugzilla old
QA Contact: reviewers → default-qa
You need to log in before you can comment on or make changes to this bug.