Closed Bug 1698598 Opened 5 years ago Closed 5 years ago

[wpt-sync] Sync PR 28082 - URLPattern: Compile regexp with `u` flag.

Categories

(Testing :: web-platform-tests, task, P4)

task

Tracking

(firefox88 fixed)

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Attachments

(1 file)

Sync web-platform-tests PR 28082 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28082
Details from upstream follow.

b'Ben Kelly <wanderview@chromium.org>' wrote:

URLPattern: Compile regexp with u flag.

This CL enables unicode mode when compiling the internal regexp. This
is the recommended mode for new features. One benefit we get here is
that the regexp compilation will fail for unknown escape sequences which
helps allow future escape sequences to be added to the standard.

It turns out, however, that path-to-regexp was over-escaping its
regular expressions. So we had to remove =, !, and : from the
list of characters to escape.

This has all been discussed on:

https://github.com/WICG/urlpattern/issues/25

Bug: 1141510
Change-Id: Id4eb6ceaa3b4aa0bb9bc33e200cd40d0b65feb49

Reviewed-on: https://chromium-review.googlesource.com/2758148
WPT-Export-Revision: f20962befb7b7259a10816d593cdedb6e896e3f0

Attached file Notable wpt changes
# CI Results Ran 0 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 4 tests and 182 subtests ## Status Summary ### Firefox OK : 4 PASS : 4 FAIL : 724 ### Chrome OK : 4 PASS : 36 FAIL : 692 ### Safari OK : 3 PASS : 3 FAIL : 543 ERROR: 1 ## Links [GitHub PR Head](https://wpt.fyi/results/?sha=bcd3abc3d1c9696be2f330505fe7f508e92d6869&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=bcd3abc3d1c9696be2f330505fe7f508e92d6869&label=pr_base) ## Details (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/cd6ab87d9ce4 [wpt PR 28082] - URLPattern: Compile regexp with `u` flag., a=testonly https://hg.mozilla.org/integration/autoland/rev/a8a2426f02b2 [wpt PR 28082] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: