Text for date format in input type=date is misplaced
Categories
(Core :: Layout: Form Controls, defect)
Tracking
()
| Tracking | Status | |
|---|---|---|
| firefox-esr78 | --- | unaffected |
| firefox86 | --- | unaffected |
| firefox87 | --- | wontfix |
| firefox88 | --- | wontfix |
| firefox89 | --- | fixed |
People
(Reporter: calixte, Assigned: emilio)
References
(Regression)
Details
(Keywords: regression)
Attachments
(7 files)
image.png
With the following code
<div style="position: absolute; top:0px; left:0px; transform: matrix(4, 0, 0, 4, 0, 0);">
<div style="position:absolute; top:10px; left:10px; font-family: Times New Roman;font-size: 8px; width:81.1px; height:14.17px;">
<input style="font: inherit; width:100%; height:100%" type="date" />
</div>
</div>
in firefox nighty 20210312215843, the text for mm/dd/yyyy is too low.
|
||
Comment 1•3 years ago
|
||
Emilio, is this an expected outcome?
|
||
Updated•3 years ago
|
|
Assignee | |
Comment 2•3 years ago
|
||
|
|
Assignee | |
Comment 3•3 years ago
|
||
What am I missing? Was this fixed elsewhere? I still think there are some improvements to be made here (baseline is a bit off) but it looks fine here to me.
|
|
Assignee | |
Comment 4•3 years ago
|
||
Mostly a cosmetic change but this makes the layout more consistent with
other form controls.
This is the only thing that I think could cause something like comment 0
is describing, though I couldn't reproduce. But I think it's an
improvement regardless.
|
||
Updated•3 years ago
|
|
Reporter | |
Comment 5•3 years ago
|
||
Interesting.
The issue is reproducable for me in removing <!DOCTYPE html> which is an error of course so you can consider that the test case is wrong and so the bug isn't a bug.
I met the bug irl in implementing some form stuff in pdf.js and the nodes are created with document.createElement.
I'll try to make a better test case.
|
|
Assignee | |
Comment 6•3 years ago
|
||
Ah, I wasn't expecting quirks mode to have an effect here :-(
|
|
Assignee | |
Comment 7•3 years ago
|
||
Yeah, so the quirks vs. no-quirks difference is just box-sizing. This is a bit broken indeed.
|
|
Reporter | |
Comment 8•3 years ago
|
||
And I've some box-sizing: border-box in the css so it explains why I hit this bug.
|
|
Assignee | |
Updated•3 years ago
|
|
|
Assignee | |
Comment 9•3 years ago
|
||
My updated patch addresses it.
|
|
Assignee | |
Comment 10•3 years ago
|
||
Ideally nsDateTimeControlFrame should / could inherit from
nsTextControlFrame, but this should do for now.
Test also covers the previous patch.
|
||
Updated•3 years ago
|
|
||
Updated•3 years ago
|
|
|
Assignee | |
Updated•3 years ago
|
|
||
Comment 11•3 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/1adc903a5a23 Prevent datetime reset button from growing the wrapper (and thus moving the editor). r=jwatt
|
||
Comment 12•3 years ago
|
||
Backed out for WR failres on transform-input-009.html
Backout link: https://hg.mozilla.org/integration/autoland/rev/7a70591b9883ff34d3c1c09f9618cde1b2048de2
Log link: https://treeherder.mozilla.org/logviewer?job_id=334940084&repo=autoland&lineNumber=10876
|
|
Assignee | |
Updated•3 years ago
|
|
|
||
Comment 13•3 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/8babc4eddd52 Prevent datetime reset button from growing the wrapper (and thus moving the editor). r=jwatt
|
|
||
Comment 14•3 years ago
|
||
Pushed by ealvarez@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/65ea7d9ad2bf Ensure baseline for text and date controls matches. r=jwatt
|
||
Comment 15•3 years ago
|
||
| bugherder | ||
|
|
Assignee | |
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
||
Updated•3 years ago
|
|
|
||
Comment 16•3 years ago
|
||
Pushed by emilio@crisal.io: https://hg.mozilla.org/integration/autoland/rev/a71cbab182a0 Remove stray printf. DONTBUILD
|
||
Comment 17•3 years ago
|
||
| bugherder | ||
|
|
||
Comment 18•3 years ago
|
||
The patch landed in nightly and beta is affected.
:emilio, is this bug important enough to require an uplift?
If not please set status_beta to wontfix.
For more information, please visit auto_nag documentation.
Description
•