Closed Bug 1698645 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28087 - Add FileSystemHandle::Remove method

Categories

(Testing :: web-platform-tests, task, P4)

Product:
Testing
Component:
web-platform-tests
Type:
task

Tracking

(firefox91 fixed)

Status:
RESOLVED FIXED
Milestone:
91 Branch
Tracking Flags:
Tracking Status
firefox91 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28087 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28087
Details from upstream follow.

b'Austin Sullivan <asully@chromium.org>' wrote:

Add FileSystemHandle::Remove method

Currently, it is not possible to remove a file or directory given its
handle. You must obtain the handle of the parent directory and call
FileSystemDirectoryHandle::RemoveEntry.

This CL allows for the removal of a file or directory from the local
file system without needing the handle of its parent.

Bug: 1114923
Change-Id: I1db1ef54e6c3a15069a3b8afa100b34f3f912e00
Reviewed-on: https://chromium-review.googlesource.com/2732700
WPT-Export-Revision: 35bc97edf7564afdf9112eea425cccf32e35448a

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 4 tests and 9 subtests

Status Summary

Firefox

OK : 4
FAIL: 32

Chrome

OK : 4
PASS: 18
FAIL: 14

Safari

OK : 4
FAIL: 32

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any.worker.html
remove() to remove a file: FAIL (Chrome: FAIL, Safari: FAIL)
remove() on an already removed file should fail: FAIL (Chrome: FAIL, Safari: FAIL)
remove() to remove an empty directory: FAIL (Chrome: FAIL, Safari: FAIL)
remove() on an already removed directory should fail: FAIL (Chrome: FAIL, Safari: FAIL)
remove() on a non-empty directory should fail: FAIL (Chrome: FAIL, Safari: FAIL)
remove() on a directory recursively should delete all sub-items: FAIL (Chrome: FAIL, Safari: FAIL)
remove() on a file should ignore the recursive option: FAIL (Chrome: FAIL, Safari: FAIL)
/file-system-access/sandboxed_FileSystemBaseHandle-remove.https.any.html
remove() to remove a file: FAIL (Chrome: FAIL, Safari: FAIL)
remove() on an already removed file should fail: FAIL (Chrome: FAIL, Safari: FAIL)
remove() to remove an empty directory: FAIL (Chrome: FAIL, Safari: FAIL)
remove() on an already removed directory should fail: FAIL (Chrome: FAIL, Safari: FAIL)
remove() on a non-empty directory should fail: FAIL (Chrome: FAIL, Safari: FAIL)
remove() on a directory recursively should delete all sub-items: FAIL (Chrome: FAIL, Safari: FAIL)
remove() on a file should ignore the recursive option: FAIL (Chrome: FAIL, Safari: FAIL)
/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any.worker.html
removeEntry() to remove a file: FAIL (Chrome: PASS, Safari: FAIL)
removeEntry() on an already removed file should fail: FAIL (Chrome: PASS, Safari: FAIL)
removeEntry() to remove an empty directory: FAIL (Chrome: PASS, Safari: FAIL)
removeEntry() on a non-empty directory should fail: FAIL (Chrome: PASS, Safari: FAIL)
removeEntry() on a directory recursively should delete all sub-items: FAIL (Chrome: PASS, Safari: FAIL)
removeEntry() with empty name should fail: FAIL (Chrome: PASS, Safari: FAIL)
removeEntry() with "." name should fail: FAIL (Chrome: PASS, Safari: FAIL)
removeEntry() with ".." name should fail: FAIL (Chrome: PASS, Safari: FAIL)
removeEntry() with a path separator should fail.: FAIL (Chrome: PASS, Safari: FAIL)
/file-system-access/sandboxed_FileSystemDirectoryHandle-removeEntry.https.any.html
removeEntry() to remove a file: FAIL (Chrome: PASS, Safari: FAIL)
removeEntry() on an already removed file should fail: FAIL (Chrome: PASS, Safari: FAIL)
removeEntry() to remove an empty directory: FAIL (Chrome: PASS, Safari: FAIL)
removeEntry() on a non-empty directory should fail: FAIL (Chrome: PASS, Safari: FAIL)
removeEntry() on a directory recursively should delete all sub-items: FAIL (Chrome: PASS, Safari: FAIL)
removeEntry() with empty name should fail: FAIL (Chrome: PASS, Safari: FAIL)
removeEntry() with "." name should fail: FAIL (Chrome: PASS, Safari: FAIL)
removeEntry() with ".." name should fail: FAIL (Chrome: PASS, Safari: FAIL)
removeEntry() with a path separator should fail.: FAIL (Chrome: PASS, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/a2a3d427efff
[wpt PR 28087] - Add FileSystemHandle::Remove method, a=testonly
https://hg.mozilla.org/integration/autoland/rev/4b0aee84fb95
[wpt PR 28087] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/a2a3d427efff
https://hg.mozilla.org/mozilla-central/rev/4b0aee84fb95

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox91: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 91 Branch
You need to log in before you can comment on or make changes to this bug.