1698668 - Improve native menu tests

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, task)

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1698668 - Replace tabs with spaces in this test. r=harry

Depends on D108547

Comment 2

[Markus Stange [:mstange]]

Attachment: Bug 1698668 - Add an activateItem function to this test which returns the activated command, and use it in testItem. r=harry

Depends on D108548

Comment 3

[Markus Stange [:mstange]]

Attachment: Bug 1698668 - Replace most uses of testItem with uses of is and activateItem, for better errors messages. r=harry

Depends on D108549

Comment 4

[Markus Stange [:mstange]]

Attachment: Bug 1698668 - Add (unused) Dump methods to nsMenuX and nsMenuItemX that can be used during debugging. r=harry

Depends on D108550

Comment 5

[Markus Stange [:mstange]]

Attachment: Bug 1698668 - Add two helper methods to nsMenuUtilsX that print out the native menu tree. r=harry

These functions aren't used by anything but they can be used during debugging.

Example output:

NSMenuItem [0x136263660] (no title)       [hasSubmenu]
  NSMenu [0x13079ec00] (no title)
    [0] NSMenuItem [0x13666cac0] Foo              [hasSubmenu]
      NSMenu [0x13079ec40] Foo
        [0] NSMenuItem [0x137093c10] FooItem0
        [1] NSMenuItem [0x1372a5dd0] FooItem1
        [2] NSMenuItem [0x1372a5a50] ----
        [3] NSMenuItem [0x1372a50b0] Bar              [hasSubmenu]
          NSMenu [0x13711ae00] Bar
            [0] NSMenuItem [0x1372a5890] BarItem0
            [1] NSMenuItem [0x1372a57b0] BarItem1

Depends on D108551

Comment 6

[Markus Stange [:mstange]]

Attachment: Bug 1698668 - Check the consistency of the native menu structure at the beginning of ActivateNativeMenuItemAt, both for the native menu bar and for standalone native menus. r=harry

These methods are only called during automated tests.

Depends on D108552

Comment 7

[Markus Stange [:mstange]]

Attachment: Bug 1698668 - Reject out-of-range indexes when walking a menu path. r=harry

Depends on D108553

Comment 8

[Markus Stange [:mstange]]

Attachment: Bug 1698668 - Adjust indexes in this subtest so that we can remove the todo_. r=harry

Comment 9

[Markus Stange [:mstange]]

Attachment: Bug 1698668 - Add a standaloneNativeMenu.dump() method that can be called from a test for debugging purposes. r=harry

Depends on D108555

Comment 10

[Markus Stange [:mstange]]

Attachment: Bug 1698668 - Allow calling nsStandaloneNativeMenu::ForceUpdateNativeMenuAt with an empty string, to force rebuilding of the root menu. r=harry

This could already be achieved by calling standaloneNativeMenu.menuOpened(),
except for the MenuClosed() call.

Depends on D108729

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0dadedbc2296
Replace tabs with spaces in this test. r=harry
https://hg.mozilla.org/integration/autoland/rev/b34bb3f93d93
Add an activateItem function to this test which returns the activated command, and use it in testItem. r=harry
https://hg.mozilla.org/integration/autoland/rev/578e3c253d63
Replace most uses of testItem with uses of is and activateItem, for better errors messages. r=harry
https://hg.mozilla.org/integration/autoland/rev/323aec581a72
Add (unused) Dump methods to nsMenuX and nsMenuItemX that can be used during debugging. r=harry
https://hg.mozilla.org/integration/autoland/rev/2103e73c06eb
Add two helper methods to nsMenuUtilsX that print out the native menu tree. r=harry
https://hg.mozilla.org/integration/autoland/rev/f23864cbe0aa
Check the consistency of the native menu structure at the beginning of ActivateNativeMenuItemAt, both for the native menu bar and for standalone native menus. r=harry
https://hg.mozilla.org/integration/autoland/rev/9e5748ce4162
Reject out-of-range indexes when walking a menu path. r=harry
https://hg.mozilla.org/integration/autoland/rev/297659ddd8cd
Add a standaloneNativeMenu.dump() method that can be called from a test for debugging purposes. r=harry
https://hg.mozilla.org/integration/autoland/rev/415cd8195d36
Allow calling nsStandaloneNativeMenu::ForceUpdateNativeMenuAt with an empty string, to force rebuilding of the root menu. r=harry
https://hg.mozilla.org/integration/autoland/rev/1f3def02a98d
Adjust indexes in this subtest so that we can remove the todo_. r=harry

Comment 12

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/0dadedbc2296
https://hg.mozilla.org/mozilla-central/rev/b34bb3f93d93
https://hg.mozilla.org/mozilla-central/rev/578e3c253d63
https://hg.mozilla.org/mozilla-central/rev/323aec581a72
https://hg.mozilla.org/mozilla-central/rev/2103e73c06eb
https://hg.mozilla.org/mozilla-central/rev/f23864cbe0aa
https://hg.mozilla.org/mozilla-central/rev/9e5748ce4162
https://hg.mozilla.org/mozilla-central/rev/297659ddd8cd
https://hg.mozilla.org/mozilla-central/rev/415cd8195d36
https://hg.mozilla.org/mozilla-central/rev/1f3def02a98d