1698706 - MozStackWalk doesn't work in Linux ASAN builds

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Comment 1

[Mike Hommey [:glandium]]

https://searchfox.org/mozilla-central/source/xpcom/threads/nsTimerImpl.cpp#599 is also not used for the same root cause.

Comment 2

[Mike Hommey [:glandium]]

It's a cousin of bug 1513605.

Comment 3

[Mike Hommey [:glandium]]

Attachment: Bug 1698706 - Always add PIC flags to C{,XX}FLAGS.

The build always uses them anyways, but configure tests don't, and some
of them fail as a consequence in some cases (example: when UBsan is
enabled, all AC_LANG_CPLUSPLUS + AC_CHECK_FUNCS tests fail). We also had
similar problems in the past, such as bug 1513605.

By adding the PIC flags to CFLAGS and CXXFLAGS, we ensure old-configure
tests use the flags as well.

While here, we also remove DSO_CFLAGS, which was always empty, and we
stop passing -fPIC to wasm compiles, because it has no effect there.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/86089c4629b5
Always add PIC flags to C{,XX}FLAGS. r=firefox-build-system-reviewers,andi,sheehan,mhentges

Comment 5

[Natalia Csoregi [:nataliaCs]]

Backed out for spidermonkey bustage.

backout: https://hg.mozilla.org/integration/autoland/rev/23e2ca5ed05d7ca25b1e9a0bc69eeae88694291b

push: https://treeherder.mozilla.org/jobs?repo=autoland&revision=86089c4629b536b7212977fffe302dad8bdc0767&group_state=expanded

failure log: https://treeherder.mozilla.org/logviewer?job_id=333475736&repo=autoland&lineNumber=1654

[task 2021-03-17T01:36:50.758Z] make[2]: Leaving directory '/builds/worker/workspace/obj-spider'
[task 2021-03-17T01:36:50.758Z] make[1]: *** [/builds/worker/checkouts/gecko/config/recurse.mk:34: compile] Error 2
[task 2021-03-17T01:36:50.758Z] make[1]: Leaving directory '/builds/worker/workspace/obj-spider'
[task 2021-03-17T01:36:50.759Z] make: *** [/builds/worker/checkouts/gecko/config/rules.mk:355: default] Error 2
[task 2021-03-17T01:36:50.759Z] make: Leaving directory '/builds/worker/workspace/obj-spider'
[task 2021-03-17T01:36:50.759Z] Traceback (most recent call last):
[task 2021-03-17T01:36:50.759Z] File "/builds/worker/checkouts/gecko/js/src/devtools/automation/autospider.py", line 518, in <module>
[task 2021-03-17T01:36:50.759Z] run_command("%s -w %s" % (MAKE, MAKEFLAGS), shell=True, check=True)
[task 2021-03-17T01:36:50.759Z] File "/builds/worker/checkouts/gecko/js/src/devtools/automation/autospider.py", line 429, in run_command
[task 2021-03-17T01:36:50.759Z] raise subprocess.CalledProcessError(status, command, output=stderr)
[task 2021-03-17T01:36:50.759Z] subprocess.CalledProcessError: Command 'make -w -j6' returned non-zero exit status 2.
[task 2021-03-17T01:36:50.766Z] + BUILD_STATUS=1

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f192e1b76d6
Always add PIC flags to C{,XX}FLAGS. r=firefox-build-system-reviewers,andi,sheehan,mhentges

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d624f866fbe0
Fix linux build bustage. a=bustage-fix CLOSED TREE

Comment 8

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/9f192e1b76d6
https://hg.mozilla.org/mozilla-central/rev/d624f866fbe0