1698712 - [wpt-sync] Sync PR 28095 - bind-gen: Apply ToV8Traits to IDL nullable types in IDL interface

Status: RESOLVED FIXED

(Core :: DOM: Security, task, P4)

Description

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 28095 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28095
Details from upstream follow.

b'Canon Mukai <[e-mail]>' wrote:

bind-gen: Apply ToV8Traits to IDL nullable types in IDL interface

This CL applies a new from-Blink-to-V8 conversion system to
IDL nullable types in IDL interface.

It also makes a change on a webtest of getTypeMapping() in
TrustedTypePolicyFactory-getPropertyType.tentative.html.
This test expects to get JS undefined probably because the old ToV8
currently gets the input value as a non-nullable object
and it returns JS undefined. However, getTypeMapping() is defined
as a nullable object attribute in the idl file.
So the web test should expect to get JS null instead of JS undefined.

Bug: 1172074
Change-Id: I07a6db64ffa3508bc4545bab539c42fee824ba7c

Reviewed-on: https://chromium-review.googlesource.com/2760717
WPT-Export-Revision: 426b3c52d29b92414aafd65034f39fc04d6b3e77

Comment 1

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=ef846221204a974a753440d602d182af3dc31155

Comment 2

[Web Platform Test Sync Bot (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 24 subtests

Status Summary

Firefox

OK : 1
FAIL: 24

Chrome

OK : 1
PASS: 23
FAIL: 1

Safari

OK : 1
FAIL: 24

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/trusted-types/TrustedTypePolicyFactory-getPropertyType.tentative.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
sanity check trustedTypes.getPropertyType for the HTML script element.: FAIL (Chrome: PASS, Safari: FAIL)
sanity check trustedTypes.getAttributeType.: FAIL (Chrome: PASS, Safari: FAIL)
sanity check trustedTypes.getTypeMapping: FAIL (Chrome: PASS, Safari: FAIL)
getPropertyType tests adapted from WICG/trusted-types polyfill: FAIL (Chrome: PASS, Safari: FAIL)
getAttributeType tests adapted from WICG/trusted-types polyfill: FAIL (Chrome: PASS, Safari: FAIL)
getTypeMapping tests adapted from WICG/trusted-types polyfill: FAIL (Chrome: FAIL, Safari: FAIL)
object[codeBase] is defined: FAIL (Chrome: PASS, Safari: FAIL)
object.codeBase is maybe defined: FAIL (Chrome: PASS, Safari: FAIL)
OBJECT[codeBase] is defined: FAIL (Chrome: PASS, Safari: FAIL)
OBJECT.codeBase is maybe defined: FAIL (Chrome: PASS, Safari: FAIL)
oBjEcT[codeBase] is defined: FAIL (Chrome: PASS, Safari: FAIL)
oBjEcT.codeBase is maybe defined: FAIL (Chrome: PASS, Safari: FAIL)
object[CODEBASE] is defined: FAIL (Chrome: PASS, Safari: FAIL)
object.CODEBASE is maybe defined: FAIL (Chrome: PASS, Safari: FAIL)
OBJECT[CODEBASE] is defined: FAIL (Chrome: PASS, Safari: FAIL)
OBJECT.CODEBASE is maybe defined: FAIL (Chrome: PASS, Safari: FAIL)
oBjEcT[CODEBASE] is defined: FAIL (Chrome: PASS, Safari: FAIL)
oBjEcT.CODEBASE is maybe defined: FAIL (Chrome: PASS, Safari: FAIL)
object[codebase] is defined: FAIL (Chrome: PASS, Safari: FAIL)
object.codebase is maybe defined: FAIL (Chrome: PASS, Safari: FAIL)
OBJECT[codebase] is defined: FAIL (Chrome: PASS, Safari: FAIL)
OBJECT.codebase is maybe defined: FAIL (Chrome: PASS, Safari: FAIL)
oBjEcT[codebase] is defined: FAIL (Chrome: PASS, Safari: FAIL)
oBjEcT.codebase is maybe defined: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/trusted-types/TrustedTypePolicyFactory-getPropertyType.tentative.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5edba05e117c
[wpt PR 28095] - bind-gen: Apply ToV8Traits to IDL nullable types in IDL interface, a=testonly

Comment 4

[Cosmin Sabou [:CosminS]]

https://hg.mozilla.org/mozilla-central/rev/5edba05e117c