1698723 - Links in PDF files should open in a browser

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Geoff Lankow (:darktrojan)]

Links to web pages from PDFs should not open in the same tab, but in a the user's browser.

This would be handled by the LinkHandler actor, except that it doesn't handle links in mail messages. I'm not sure what to do about that.

Comment 1

[Geoff Lankow (:darktrojan)]

Actually, if I add onclick="return contentAreaClick(event);" to the tab's browser, that should get handled, because PDF attachments are displayed in the parent process. The actor isn't involved at all. I wonder if there are any side-effects.

Comment 2

[Geoff Lankow (:darktrojan)]

Attachment: Bug 1698723 - Restore an onclick handler to content tabs. r?mkmelin

The added handler only affects parent process content tabs. It's the same as the handler on the message pane.

I've disabled the link handling actor for parent process browsers so that only the onclick handler is in effect for them.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/cf1486a70494
Restore an onclick handler to content tabs. r=mkmelin

Comment 4

[John Bieling (:TbSync)]

I would like to request back-out of this. As pointed out 8 days ago, this causes regressions in the add-on manager and today I realized I can no longer change options in the settings page of the add-on inspector. After backing this out locally, both works again.

Comment 5

[Magnus Melin [:mkmelin]]

Did you file a bug about the regressions?

Comment 6

[John Bieling (:TbSync)]

Yes, bug 1707503, listed above Comment 4.

Comment 7

[John Bieling (:TbSync)]

Bug 1711841 is also a regression. Could you have a look?