Closed Bug 1698724 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28037 - WebKit export of https://bugs.webkit.org/show_bug.cgi?id=203456

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28037 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28037
Details from upstream follow.

b'Alexey Shvayka <shvaikalesh@gmail.com>' wrote:

WebKit export of https://bugs.webkit.org/show_bug.cgi?id=203456

This upstream reviewed change tests (via [[DefineOwnProperty]]) that descriptors of unforgeable global properties are accessor ones.

In WebKit, document and window are defined internally as read-only descriptor properties (for performance reasons), and require extra care in WindowProxy's [[DefineOwnProperty]].

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 8 subtests

Status Summary

Firefox

OK : 1
FAIL: 8

Chrome

OK : 1
PASS: 8

Safari

OK : 1
PASS: 2
FAIL: 6

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Firefox-only Failures

/html/browsers/the-windowproxy-exotic-object/windowproxy-define-own-property-unforgeable-same-origin.html
[[DefineOwnProperty]] success: "top": FAIL
[[DefineOwnProperty]] failure: "top": FAIL

New Tests That Don't Pass

/html/browsers/the-windowproxy-exotic-object/windowproxy-define-own-property-unforgeable-same-origin.html
[[DefineOwnProperty]] success: "window": FAIL (Chrome: PASS, Safari: FAIL)
[[DefineOwnProperty]] failure: "window": FAIL (Chrome: PASS, Safari: FAIL)
[[DefineOwnProperty]] success: "document": FAIL (Chrome: PASS, Safari: FAIL)
[[DefineOwnProperty]] failure: "document": FAIL (Chrome: PASS, Safari: FAIL)
[[DefineOwnProperty]] success: "location": FAIL (Chrome: PASS, Safari: FAIL)
[[DefineOwnProperty]] failure: "location": FAIL (Chrome: PASS, Safari: FAIL)
[[DefineOwnProperty]] success: "top": FAIL (Chrome: PASS, Safari: PASS)
[[DefineOwnProperty]] failure: "top": FAIL (Chrome: PASS, Safari: PASS)

Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.