1698728 - [wpt-sync] Sync PR 28046 - Revert "Improve counterscroll handling"

Status: RESOLVED FIXED

(Testing :: web-platform-tests, task, P4)

Description

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Sync web-platform-tests PR 28046 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28046
Details from upstream follow.

b'Xianzhu Wang <[e-mail]>' wrote:

Revert "Improve counterscroll handling"

This reverts commit c3a63721ee0613b73066c5166109c0dd054b926e.

Reason for revert: Caused CLS benchmark regressions. Some are expected,
like the change in shift-while-scrolled.html. Some look problematic,
e.g. some results changed from 0 to non-0. Needs investigation.

Original change's description:

Improve counterscroll handling

Previously we tracked the maximum scroll offset in a viewport to ignore
counterscroll shifts, but it failed when

• There were multiple scrollers scroll at the same time. Tested by
  external/wpt/layout-instability/shift-with-counterscroll-2.html.
• An invisible shift was countered by both scroll and transform, e.g.
  move layout location by 100px, scroll by -50px, and transform by
  -50px. Tested by
  external/wpt/layout-instability/shift-with-counter-scroll-and-transform.html

Now let PaintPropertyTreeBuilder track scroll delta, and pass the delta
to LayoutShiftTracker.

Bug: 1182213
Change-Id: I18366ff7bc0e96374a954bee1c1600b582681dd8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2741240
Commit-Queue: Xianzhu Wang \<[e-mail]>
Reviewed-by: Chris Harrelson \<[e-mail]>
Reviewed-by: Steve Kobes \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#861702}

Bug: 1182213, 1186894
Change-Id: I69ccdb7d132f73618777530e932578fbadee35e7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2754072
Bot-Commit: Rubber Stamper \<[e-mail]>
Commit-Queue: Xianzhu Wang \<[e-mail]>
Cr-Commit-Position: refs/heads/master@{#862256}

Comment 1

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

PR 28046 applied with additional changes from upstream: e2e37cfbbdf3c707e45867ba8615504236076cee

Comment 2

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=264f7c0b3e28017442cad43ed34b1c57dba75156

Comment 3

[Web Platform Test Sync Bot [:wpt-sync] (Matrix: #interop:mozilla.org)]

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL: 2

Chrome

OK : 2
PASS: 2

Safari

OK : 2
FAIL: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/layout-instability/shift-while-scrolled.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Layout shift with non-zero scroll offset.: FAIL (Chrome: PASS, Safari: FAIL)
/layout-instability/shift-with-counterscroll.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
Shift with counterscroll not counted.: FAIL (Chrome: PASS, Safari: FAIL)

Tests Disabled in Gecko Infrastructure

/layout-instability/shift-while-scrolled.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)
/layout-instability/shift-with-counterscroll.html: OK [GitHub], SKIP [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-qr-opt, Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-debug, Gecko-windows10-64-opt, Gecko-windows10-64-qr-debug, Gecko-windows10-64-qr-opt, Gecko-windows7-32-debug, Gecko-windows7-32-opt] (Chrome: OK, Safari: OK)

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c42371e26c68
[wpt PR 28046] - Revert "Improve counterscroll handling", a=testonly

Comment 5

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c42371e26c68