Closed Bug 1698730 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28041 - Workaround for legacy markers leaving empty anonymous blocks

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
88 Branch
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28041 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28041
Details from upstream follow.

b'Rune Lillesveen <futhark@chromium.org>' wrote:

Workaround for legacy markers leaving empty anonymous blocks

We should not leave empty anonymous block boxes, but we intentionally do
that in LayoutListItem::UpdateMarkerLocation(). This change skips empty
anonymous block boxes looking for ::first-letter text.

Fixes a fuzzer crash.

Bug: 1174985
Change-Id: Ibb3a869c9c3d80b49e2dc8d3a64b86c472584340
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2754547
Reviewed-by: Oriol Brufau \<obrufau@igalia.com>
Reviewed-by: Morten Stenshorne \<mstensho@chromium.org>
Commit-Queue: Rune Lillesveen \<futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#862345}

Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 1 tests and 1 subtests

Status Summary

Firefox

OK : 1
PASS: 1

Chrome

OK : 1
FAIL: 1

Safari

OK : 1
PASS: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/de6f4943050f
[wpt PR 28041] - Workaround for legacy markers leaving empty anonymous blocks, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.