Closed Bug 1698739 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 27910 - HighlightAPI: Introduce feature flag and OM types.

Categories

(Core :: CSS Parsing and Computation, task, P4)

Product:
Core
Component:
CSS Parsing and Computation
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 27910 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/27910
Details from upstream follow.

b'Fernando Fiori <ffiori@microsoft.com>' wrote:

HighlightAPI: Introduce feature flag and OM types.

Bug: 1166724
Change-Id: Ib4e6327fd0867c26df66a8d6fa12b60d195b0844
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2720067
Reviewed-by: Sanket Joshi \<sajos@microsoft.com>
Reviewed-by: Rune Lillesveen \<futhark@chromium.org>
Commit-Queue: Fernando Fiori \<ffiori@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#862024}

Component: web-platform-tests → CSS Parsing and Computation
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 2 subtests

Status Summary

Firefox

OK : 2
FAIL: 28

Chrome

OK : 2
FAIL: 28

Safari

OK : 2
FAIL: 28

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-highlight-api/Highlight-setlike.html
Highlight initializes empty (if no ranges are provided) and with priority 0.: FAIL (Chrome: FAIL, Safari: FAIL)
Highlight add and has methods work as expected (using the following combination of ranges [[object Range], [object Range], [object Range]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight delete method works as expected (using the following combination of ranges [[object Range], [object Range], [object Range]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight constructor behaves like a set when using equal ranges (using the following combination of ranges [[object Range], [object Range], [object Range]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight constructor works as expected when called with one range (using the following combination of ranges [[object Range], [object Range], [object Range]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight constructor works as expected when called with two ranges (using the following combination of ranges [[object Range], [object Range], [object Range]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight clear method works as expected (using the following combination of ranges [[object Range], [object Range], [object Range]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight add and has methods work as expected (using the following combination of ranges [[object StaticRange], [object StaticRange], [object StaticRange]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight delete method works as expected (using the following combination of ranges [[object StaticRange], [object StaticRange], [object StaticRange]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight constructor behaves like a set when using equal ranges (using the following combination of ranges [[object StaticRange], [object StaticRange], [object StaticRange]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight constructor works as expected when called with one range (using the following combination of ranges [[object StaticRange], [object StaticRange], [object StaticRange]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight constructor works as expected when called with two ranges (using the following combination of ranges [[object StaticRange], [object StaticRange], [object StaticRange]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight clear method works as expected (using the following combination of ranges [[object StaticRange], [object StaticRange], [object StaticRange]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight add and has methods work as expected (using the following combination of ranges [[object Range], [object StaticRange], [object Range]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight delete method works as expected (using the following combination of ranges [[object Range], [object StaticRange], [object Range]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight constructor behaves like a set when using equal ranges (using the following combination of ranges [[object Range], [object StaticRange], [object Range]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight constructor works as expected when called with one range (using the following combination of ranges [[object Range], [object StaticRange], [object Range]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight constructor works as expected when called with two ranges (using the following combination of ranges [[object Range], [object StaticRange], [object Range]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight clear method works as expected (using the following combination of ranges [[object Range], [object StaticRange], [object Range]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight add and has methods work as expected (using the following combination of ranges [[object StaticRange], [object Range], [object StaticRange]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight delete method works as expected (using the following combination of ranges [[object StaticRange], [object Range], [object StaticRange]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight constructor behaves like a set when using equal ranges (using the following combination of ranges [[object StaticRange], [object Range], [object StaticRange]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight constructor works as expected when called with one range (using the following combination of ranges [[object StaticRange], [object Range], [object StaticRange]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight constructor works as expected when called with two ranges (using the following combination of ranges [[object StaticRange], [object Range], [object StaticRange]]): FAIL (Chrome: FAIL, Safari: FAIL)
Highlight clear method works as expected (using the following combination of ranges [[object StaticRange], [object Range], [object StaticRange]]): FAIL (Chrome: FAIL, Safari: FAIL)
Constructor throws on missing name argument: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-highlight-api/HighlightRegistry-setlike.html
HighlightRegistry initializes as it should.: FAIL (Chrome: FAIL, Safari: FAIL)
HighlightRegistry has a setlike interface.: FAIL (Chrome: FAIL, Safari: FAIL)

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/f6d3c8a4d518
[wpt PR 27910] - HighlightAPI: Introduce feature flag and OM types., a=testonly
https://hg.mozilla.org/integration/autoland/rev/ceef0b8a7a87
[wpt PR 27910] - Update wpt metadata, a=testonly

https://hg.mozilla.org/mozilla-central/rev/f6d3c8a4d518
https://hg.mozilla.org/mozilla-central/rev/ceef0b8a7a87

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.