1698754 - Make page info dialog look good in dark mode

Status: VERIFIED FIXED

(Core :: Widget: Cocoa, task, P2)

Description

[Martin Balfanz [:mbalfanz]]

Attachment: Screenshot 2021-03-16 at 11.02.09.png

With the patch from bug 1697331, and widget.macos.respect-system-appearance set to true, the Page info dialog looks like in the attached screenshot in macOS Dark Mode.

The problems I see are:

• alternating background colors in the table are light, while foreground is also light. This makes text unreadable (General and Media tab)
• Background seems to bright on Permissions tab
• Hover color is white on Permissions tab
• the active menu item (e.g. security) does not follow accent color
• clear cookies list background seems too bright

Comment 1

[Martin Balfanz [:mbalfanz]]

Attachment: Screenshot 2021-03-16 at 11.02.18.png

Comment 2

[Martin Balfanz [:mbalfanz]]

Attachment: Screenshot 2021-03-16 at 11.02.20.png

Comment 3

[Martin Balfanz [:mbalfanz]]

Attachment: Screenshot 2021-03-16 at 11.02.22.png

Comment 4

[Martin Balfanz [:mbalfanz]]

Attachment: Screenshot 2021-03-16 at 11.06.28.png

Comment 5

[Harry Twyford]

This was mostly fixed in bug 1698763.

Comment 6

[Harry Twyford]

Attachment: Bug 1698754 - Set listbox backgrounds to controlBackgroundColor. r?mstange

Comment 7

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/89c299ded7a2
Set listbox backgrounds to controlBackgroundColor. r=mstange

Comment 8

[Noemi Erli[:noemi_erli]]

https://hg.mozilla.org/mozilla-central/rev/89c299ded7a2

Comment 9

[Timea Zsoldos [:zstimi/tzsoldos], Desktop QA]

I have reproduced this issue using Firefox 88.0a1 (2021.03.16) on macOS 11.
I can confirm this issue is fixed, I verified using Firefox 91.0a1 and Firefox 90.0b3 on macOS 11.