Closed
Bug 1698754
Opened 4 years ago
Closed 3 years ago
Make page info dialog look good in dark mode
Categories
(Core :: Widget: Cocoa, task, P2)
Core
Widget: Cocoa
Tracking
()
Tracking | Status | |
---|---|---|
firefox90 | --- | verified |
People
(Reporter: mbalfanz, Assigned: bugzilla)
References
Details
(Whiteboard: [mac:darkmode])
Attachments
(6 files)
With the patch from bug 1697331, and widget.macos.respect-system-appearance set to true, the Page info dialog looks like in the attached screenshot in macOS Dark Mode.
The problems I see are:
- alternating background colors in the table are light, while foreground is also light. This makes text unreadable (General and Media tab)
- Background seems to bright on Permissions tab
- Hover color is white on Permissions tab
- the active menu item (e.g. security) does not follow accent color
- clear cookies list background seems too bright
Reporter | ||
Comment 1•4 years ago
|
||
Reporter | ||
Comment 2•4 years ago
|
||
Reporter | ||
Comment 3•4 years ago
|
||
Reporter | ||
Comment 4•4 years ago
|
||
Reporter | ||
Updated•4 years ago
|
Whiteboard: [mac:darkmode]
Updated•4 years ago
|
Severity: -- → S2
Priority: -- → P2
Assignee | ||
Comment 5•3 years ago
|
||
This was mostly fixed in bug 1698763.
Assignee: nobody → htwyford
Status: NEW → ASSIGNED
Iteration: --- → 90.2 - May 3 - May 16
Points: --- → 1
Depends on: 1698763
Assignee | ||
Comment 6•3 years ago
|
||
Pushed by htwyford@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/89c299ded7a2
Set listbox backgrounds to controlBackgroundColor. r=mstange
Comment 8•3 years ago
|
||
bugherder |
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
status-firefox90:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
Updated•3 years ago
|
Flags: qe-verify+
Comment 9•3 years ago
|
||
I have reproduced this issue using Firefox 88.0a1 (2021.03.16) on macOS 11.
I can confirm this issue is fixed, I verified using Firefox 91.0a1 and Firefox 90.0b3 on macOS 11.
Status: RESOLVED → VERIFIED
Updated•3 years ago
|
Flags: qe-verify+
You need to log in
before you can comment on or make changes to this bug.
Description
•