1698771 - browser_PartnerLinkAttribution.js should wait for a rebuild event on the oneOffButtons instead of relying on the implicit initial TestUtils.waitForCondition timer

Status: RESOLVED FIXED

(Firefox :: Search, task)

Description

[Florian Quèze [:florian]]

browser_PartnerLinkAttribution.js becomes a perma fail on some platforms (specifically Windows 10 x64 opt) if I fix bug 1596165.

The error I get is:
TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_PartnerLinkAttribution.js | Test timed out -
TEST-UNEXPECTED-FAIL | browser/modules/test/browser/browser_PartnerLinkAttribution.js | Found a tab after previous test timed out: https://example.com/?sourceId=Mozilla-search&search=searchbar -

Followed by this error for each of the tests that run afterwards:
A promise chain failed to handle a rejection: can't access property "isAppProvided", engine is null - stack: _updateURLBarPlaceholder@chrome://browser/content/browser.js:4071:9

Comment 1

[Florian Quèze [:florian]]

Attachment: Bug 1698771 - browser_PartnerLinkAttribution.js should wait for a rebuild event on the oneOffButtons instead of relying on the implicit initial TestUtils.waitForCondition timer, r=Standard8.

Depends on D108615

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/6dc3857184d6
browser_PartnerLinkAttribution.js should wait for a rebuild event on the oneOffButtons instead of relying on the implicit initial TestUtils.waitForCondition timer, r=Standard8.

Comment 3

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/6dc3857184d6