Closed Bug 1698776 Opened 4 years ago Closed 4 years ago

[wpt-sync] Sync PR 28098 - The sticky positioned input element in the scrollable should block scroll

Categories

(Core :: Layout: Positioned, task, P4)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

(Blocks 1 open bug, )

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28098 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28098
Details from upstream follow.

b'Seokho Song <0xdevssh@gmail.com>' wrote:

The sticky positioned input element in the scrollable should block scroll

Normally, When the input element gets keyboard events or a focus event, The scrollable area wrapped the input element scroll up to the focused/get keyboard event element.

However, The sticky positioned element should keep the scroll position when the events occur because the sticky positioned element attached enclosing scrollable-area with offset.

Therefore, Add LayoutObject::IsEnclosingStickyLayerInScrollable() function to check if sticky positioned element inside of scrollable.
Also, When the text layout mouse selection changed, the scrollable area occurs the auto-scroll. Due to this reason, add check the statement inside LayoutBox::FindAutoscrollable function.

Bug: 1178622
Change-Id: I7b9e42d1274894a0f3282316a2eb69d0d10c5530
Reviewed-on: https://chromium-review.googlesource.com/2727895
WPT-Export-Revision: e080cf0040b916f029c889c5d48820220d00da79

Component: web-platform-tests → Layout: Positioned
Product: Testing → Core

CI Results

Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 1 subtests

Status Summary

Firefox

OK : 2
FAIL: 2

Chrome

OK : 2
FAIL: 2

Safari

OK : 2
PASS: 1
FAIL: 1

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

New Tests That Don't Pass

/css/css-position/sticky/position-sticky-input-box-gets-focused-after-scroll.html
Focusing on visible sticky input box should reset the scroll to unshifted sticky position.: FAIL (Chrome: FAIL, Safari: FAIL)
/css/css-position/sticky/sticky-after-input.html
Sticky positioned element should reset the scroll position to unshifted position: FAIL (Chrome: FAIL, Safari: PASS)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/98193bd520aa [wpt PR 28098] - The sticky positioned element should reset the scroll to an unshifted position by any operation, a=testonly https://hg.mozilla.org/integration/autoland/rev/05b7d4075d0a [wpt PR 28098] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.