1698823 - java.lang.NullPointerException: WebExtension$DelegateController.getActionDelegate()

Status: RESOLVED FIXED

(GeckoView :: Extensions, defect, P1)

Description

[[ex-Mozilla] Agi Sferro | :agi]

Crash report: https://crash-stats.mozilla.org/report/index/24ec03b8-043c-4390-b5fd-3c0440210316

Java stack trace:

org.mozilla.geckoview.GeckoResult$UncaughtException: java.lang.NullPointerException: Attempt to invoke interface method 'org.mozilla.geckoview.WebExtension$ActionDelegate org.mozilla.geckoview.WebExtension$DelegateController.getActionDelegate()' on a null object reference
	at org.mozilla.geckoview.GeckoResult.dispatchLocked(GeckoResult.java:4)
	at org.mozilla.geckoview.GeckoResult.completeExceptionally(GeckoResult.java:4)
	at org.mozilla.geckoview.GeckoResult.lambda$thenInternal$4$GeckoResult(GeckoResult.java:10)
	at org.mozilla.geckoview.-$$Lambda$GeckoResult$-hYJKiV7OmgfRN8NZFvKg9ij7nk.run(Unknown Source:8)
	at org.mozilla.geckoview.GeckoResult.lambda$dispatchLocked$5(GeckoResult.java:2)
	at org.mozilla.geckoview.-$$Lambda$GeckoResult$itcI1hkT0606QBUv3dYAZ4ertbk.run(Unknown Source:2)
	at android.os.Handler.handleCallback(Handler.java:883)
	at android.os.Handler.dispatchMessage(Handler.java:100)
	at android.os.Looper.loop(Looper.java:224)
	at android.app.ActivityThread.main(ActivityThread.java:7565)
	at java.lang.reflect.Method.invoke(Native Method)
	at com.android.internal.os.RuntimeInit$MethodAndArgsCaller.run(RuntimeInit.java:539)
	at com.android.internal.os.ZygoteInit.main(ZygoteInit.java:950)
Caused by: java.lang.NullPointerException: Attempt to invoke interface method 'org.mozilla.geckoview.WebExtension$ActionDelegate org.mozilla.geckoview.WebExtension$DelegateController.getActionDelegate()' on a null object reference
	at org.mozilla.geckoview.WebExtension$Action.lambda$click$0$WebExtension$Action(WebExtension.java:2)
	at org.mozilla.geckoview.-$$Lambda$WebExtension$Action$LKJClgXm-kzeWs1XkJNxnbyR7uQ.accept(Unknown Source:4)
	at org.mozilla.geckoview.GeckoResult.lambda$accept$2(GeckoResult.java:1)
	at org.mozilla.geckoview.-$$Lambda$GeckoResult$jOTMkpkhFSpBCw69vbWxDq7m7Tw.onValue(Unknown Source:2)
	at org.mozilla.geckoview.GeckoResult.lambda$thenInternal$4$GeckoResult(GeckoResult.java:2)
	... 10 more

Comment 1

[[ex-Mozilla] Agi Sferro | :agi]

Attachment: Bug 1698823 - Don't allow null delegateController.

We used to support having a null delegateController because WebExtension could
be constructed from the app. Now that we can only go through the Controller we
don't need to do that anymore.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b559b9ec4a1a
Don't allow null delegateController. r=aklotz,droeh

Comment 3

[Atila Butkovits]

https://hg.mozilla.org/mozilla-central/rev/b559b9ec4a1a