Closed Bug 1698843 Opened 1 year ago Closed 1 year ago

Mirror cookieBehavior PBM pref with regular cookieBehavior pref in Strict and Custom

Categories

(Firefox :: Protections UI, enhancement, P2)

enhancement

Tracking

()

RESOLVED FIXED
89 Branch
Tracking Status
firefox89 --- fixed

People

(Reporter: johannh, Assigned: timhuang)

References

Details

Attachments

(7 files, 1 obsolete file)

48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review
48 bytes, text/x-phabricator-request
Details | Review

When we implement a new private browsing cookieBehavior pref and turn it on by default for standard, we want to have this new pref be a mirror of the old cookieBehavior in Strict and Custom mode.

Assignee: nobody → tihuang
Status: NEW → ASSIGNED

In this patch, we add a new content blocking category cookieBeahviorPM
for the cookieBehavior pref of the private mode.

If the user has set the cookieBehavior, then we will set the user value
to the private cookieBehavior to keep the expectation of cookieBehavior
of private mode for these users.

Depends on D111001

This patch modifies two tests browser_contentblocking.js and
browser_contentblocking_categories.js to test the private cookieBehavior
setting in custom mode.

Depends on D111005

Attachment #9213919 - Attachment description: Bug 1698843 - Part 2: Set the private cookieBehavior to the regular one if the user has a user value of it. r?pbz,johannh → Bug 1698843 - Part 2: Migrate the regular cookieBehavior to the private one if the user has a user value of it. r?pbz,johannh,dimi
Attachment #9213919 - Attachment description: Bug 1698843 - Part 2: Migrate the regular cookieBehavior to the private one if the user has a user value of it. r?pbz,johannh,dimi → Bug 1698843 - Part 2: Make the private cookieBehavior getter to return the regular pref if there is a user value for the regular pref. r?pbz,johannh,dimi
Attachment #9213923 - Attachment description: Bug 1698843 - Part 5: Set the default of the private cookieBehavior pref if the regular cookieBehavior is altered by the policy. r?Gijs → Bug 1698843 - Part 4: Set the default of the private cookieBehavior pref if the regular cookieBehavior is altered by the policy. r?Gijs
Attachment #9213924 - Attachment description: Bug 1698843 - Part 6: Modify the tests to check the behavior of setting cookieBehavior in custom mode. r?pbz,johannh → Bug 1698843 - Part 5: Modify the tests to check the behavior of setting cookieBehavior in custom mode. r?pbz,johannh
Attachment #9213925 - Attachment description: Bug 1698843 - Part 7: Set the default value of 'network.cookie.cookieBehavior.pbmode' to BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN. r?pbz,johannh → Bug 1698843 - Part 6: Set the default value of 'network.cookie.cookieBehavior.pbmode' to BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN. r?pbz,johannh

The patch adds a sub test in test_cookie_behavior.js to make sure the
mirroring works. Also, this modifies tests for them to work with the
cookieBehavior pref mirroring.

Depends on D111007

Attachment #9213922 - Attachment is obsolete: true
Pushed by tihuang@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/8896f5954b2e
Part 1: Add new content blocking category flag for 'network.cookie.cookieBehavior.pbmode' r=pbz,johannh
https://hg.mozilla.org/integration/autoland/rev/4c5fb9d17322
Part 2: Make the private cookieBehavior getter to return the regular pref if there is a user value for the regular pref. r=johannh,dimi
https://hg.mozilla.org/integration/autoland/rev/5f10c1ee8861
Part 3: Set content blocking category flag for cookieBehavior for the private mode. r=pbz,johannh
https://hg.mozilla.org/integration/autoland/rev/3c198747610a
Part 4: Set the default of the private cookieBehavior pref if the regular cookieBehavior is altered by the policy. r=mkaply
https://hg.mozilla.org/integration/autoland/rev/cb541264cf3d
Part 5: Modify the tests to check the behavior of setting cookieBehavior in custom mode. r=pbz
https://hg.mozilla.org/integration/autoland/rev/80d53e0de6e9
Part 6: Set the default value of 'network.cookie.cookieBehavior.pbmode' to BEHAVIOR_REJECT_TRACKER_AND_PARTITION_FOREIGN. r=pbz,johannh
https://hg.mozilla.org/integration/autoland/rev/77ef8676160b
Part 7: Modify tests to respect the cookieBehavior getter mirroring. r=pbz,johannh,robwu
You need to log in before you can comment on or make changes to this bug.