Closed Bug 1698854 Opened 3 years ago Closed 3 years ago

[wpt-sync] Sync PR 28103 - [ResourceTiming]: Prefer arrow-functions to function declarations

Categories

(Core :: Performance, task, P4)

Product:
Core
Component:
Performance
Type:
task

Tracking

()

Status:
RESOLVED FIXED
Milestone:
88 Branch
Tracking Flags:
Tracking Status
firefox88 --- fixed

People

(Reporter: mozilla.org, Unassigned)

References

(
URL
)

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28103 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28103
Details from upstream follow.

b'Tom McKee <tommckee@chromium.org>' wrote:

[ResourceTiming]: Prefer arrow-functions to function declarations

To help with readability, we want to have a consistent style for
function declaration within ResourceTiming's WPTs.

This change amends the style guide to recommend which function
declaration syntax we prefer. It also updates the tests we've already
'modernized' to conform to the updated style guide.

Bug: 1171767
Change-Id: I5910d4de28ad911800d2bdd416bf4fbea7062ce1
GithubIssue: https://github.com/w3c/resource-timing/issues/254

Reviewed-on: https://chromium-review.googlesource.com/2764663
WPT-Export-Revision: d6c158ff23c2ef9a432e6e0082fbd6ac489ba7df

PR 28103 applied with additional changes from upstream: 7a9388b0f029e03fab3ff197f0b654e4d8ba1af0, 9b89c07fce21e82f2afb3baa412bb8ce4094d6d5, 7179a415b40a2079f4c242023ff0c0a05cf546be, e4c9d94503962cc284249c5c7b0fee5b70cc97e5, c3e39a89830aa7f4c466d12608f7325e137333d9, c7e328dbc1ce786d621db0d5453710bbc0194bec, 67fb83ffe97cebaa9292260ec1544f699844b04e
Component: web-platform-tests → Performance
Product: Testing → Core

CI Results

Ran 12 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 2 tests and 3 subtests

Status Summary

Firefox

OK : 2
PASS : 4

Chrome

OK : 2
PASS : 4

Safari

OK : 1
PASS : 1
FAIL : 2
TIMEOUT: 2

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Pushed by wptsync@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/e52303f19170
[wpt PR 28103] - [ResourceTiming]: Prefer arrow-functions to function declarations, a=testonly

https://hg.mozilla.org/mozilla-central/rev/e52303f19170

Status: NEW → RESOLVED
Closed: 3 years ago
status-firefox88: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → 88 Branch
You need to log in before you can comment on or make changes to this bug.