[wpt-sync] Sync PR 28058 - URLPattern: Add per-component pattern getters.
Categories
(Testing :: web-platform-tests, task, P4)
Tracking
(firefox88 fixed)
Tracking | Status | |
---|---|---|
firefox88 | --- | fixed |
People
(Reporter: mozilla.org, Unassigned)
References
()
Details
(Whiteboard: [wptsync downstream])
Attachments
(1 file)
71.92 KB,
text/plain
|
Details |
Sync web-platform-tests PR 28058 into mozilla-central (this bug is closed when the sync is complete).
PR: https://github.com/web-platform-tests/wpt/pull/28058
Details from upstream follow.
b'Ben Kelly <wanderview@chromium.org>' wrote:
URLPattern: Add per-component pattern getters.
This CL exposes the parsed, canonical pattern as a property on the
URLPattern object. This canonical pattern string is generated from
the liburlpattern::Pattern object.The CL also expands on the WPT test to verify pattern string properties
are exposed properly. The test driver does most of the work and the
data file only needs to provide overrides where the canonicalization
has made the expected pattern non-obvious.Finally, this CL also drops the TODO to add a stringifier. As discussed
in the following issue we have decided not to add a stringifier for now:https://github.com/WICG/urlpattern/issues/47
Developers may try to use a stringifier as a serialization mechanism
which is something we want to avoid. The URLPattern properties,
however, are exposed and human readable in devtools.Bug: 1141510
Change-Id: Ifeacd06d5885158777b290f8eb54ed2175be7201
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2729489
Commit-Queue: Ben Kelly \<wanderview@chromium.org>
Reviewed-by: Jeremy Roman \<jbroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#863284}
Assignee | ||
Comment 1•3 years ago
|
||
Pushed to try (stability) https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6090ca965727d118a8abe641819f8ba6f10ece8
Assignee | ||
Comment 2•3 years ago
|
||
# CI Results Ran 15 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI Total 4 tests and 177 subtests ## Status Summary ### Firefox OK : 4 PASS : 4 FAIL : 704 ### Chrome OK : 4 PASS : 36 FAIL : 672 ### Safari OK : 3 PASS : 3 FAIL : 528 ERROR: 1 ## Links [Gecko CI (Treeherder)](https://treeherder.mozilla.org/#/jobs?repo=try&revision=e6090ca965727d118a8abe641819f8ba6f10ece8) [GitHub PR Head](https://wpt.fyi/results/?sha=d3166cab8fe8b497efa64fe1fdd6b5ae9f5e62e1&label=pr_head) [GitHub PR Base](https://wpt.fyi/results/?sha=d3166cab8fe8b497efa64fe1fdd6b5ae9f5e62e1&label=pr_base) ## Details (See attachment for full changes)
Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/b5ae7983c92e [wpt PR 28058] - URLPattern: Add per-component pattern getters., a=testonly
Comment 4•3 years ago
|
||
bugherder |
Description
•