Open Bug 1698937 Opened 4 years ago Updated 1 year ago

Use mozcrash.kill_and_get_minidump() for shutdown hangs

Categories

(Testing :: Marionette Client and Harness, enhancement, P3)

Product:
Testing
Component:
Marionette Client and Harness
Version:
Default
Type:
enhancement

Tracking

(Not tracked)

People

(Reporter: whimboo, Unassigned)

References

(Blocks 1 open bug)

Details

As noticed on bug 1630162 comment 21 we should better call the mozcrash specific method instead of letting mozprocess kill the Firefox process. That way we would get a reasonable minidump / crash stack for the code that caused the hang during shutdown.

Note that this should only be used for in_app=True shutdown scenarios. When this is False we SIGKILL the process anyway.

Right now I'm not sure if we can also do that for restart scenarios, but at least for shutdown it will be sufficient. Here is the code that needs to be changed:

https://hg.mozilla.org/mozilla-central/file/6b980dac220c5fcaa56546b3a85dda2f7e1ee9de/testing/marionette/client/marionette_driver/marionette.py#l1005
https://hg.mozilla.org/mozilla-central/file/6b980dac220c5fcaa56546b3a85dda2f7e1ee9de/testing/marionette/client/marionette_driver/marionette.py#l1091

Product: Testing → Remote Protocol
Component: Marionette → Marionette Client and Harness
Product: Remote Protocol → Testing

Maybe nominate this one for a "student project"?

You need to log in before you can comment on or make changes to this bug.