1698970 - ./mach perftest failing with KeyError: '_from'

Status: RESOLVED FIXED

(Testing :: mozperftest, defect, P3)

Description

[Marc Leclair [:mleclair]]

Tried running ./mach perftest with a few options and it fails. Here's the output:

Good job! Best selection.
testing/performance/perftest_android_view.js
Error running mach:

    ['perftest', '--flavor', 'mobile-browser', '--android', '--android-app-name', 'org.mozilla.fenix', '--perfherder-metrics', 'processLaunchToNavStart', '--android-clear-logcat', '--android-capture-logcat', 'logcat', '--android-activity', 'org.mozilla.fenix.IntentReceiverActivity', '--hooks', 'testing/performance/hooks_android_view.py', '--perfherder', '--perfherder-app', 'fenix', '--browsertime-install-url', 'https://github.com/sitespeedio/browsertime/tarball/2171125113c7bfa01b98523cdc8bad22de17cd0f', '--browsertime-iterations', '25', '--output', 'sb/artifacts', 'testing/performance/perftest_android_view.js']

The error occurred in code that was called by the mach command. This is either
a bug in the called code itself or in the way that mach is calling it.
You can invoke |./mach busted| to check if this issue is already on file. If it
isn't, please use |./mach busted file perftest| to report it. If |./mach busted| is
misbehaving, you can also inspect the dependencies of bug 1543241.

If filing a bug, please include the full output of mach, including this error
message.

The details of the failure are as follows:

KeyError: '_from'

  File "/Users/mleclair/repositories/mozilla-central/python/mozperftest/mozperftest/mach_commands.py", line 159, in run_perftest
    run_tests(self, kwargs, original_parser.get_user_args(kwargs))
  File "/Users/mleclair/repositories/mozilla-central/python/mozperftest/mozperftest/runner.py", line 163, in run_tests
    e.run(metadata)
  File "/Users/mleclair/repositories/mozilla-central/python/mozperftest/mozperftest/environment.py", line 92, in run
    with self.layers[SYSTEM] as syslayer, self.layers[TEST] as testlayer:
  File "/Users/mleclair/repositories/mozilla-central/python/mozperftest/mozperftest/layers.py", line 137, in __enter__
    self.setup()
  File "/Users/mleclair/repositories/mozilla-central/python/mozperftest/mozperftest/layers.py", line 147, in setup
    layer.setup()
  File "/Users/mleclair/repositories/mozilla-central/python/mozperftest/mozperftest/test/browsertime/runner.py", line 183, in setup
    if not self._should_install() and not self.get_arg("clobber"):
  File "/Users/mleclair/repositories/mozilla-central/python/mozperftest/mozperftest/test/browsertime/runner.py", line 159, in _should_install
    return not old_pkg["_from"].endswith(new_pkg["devDependencies"]["browsertime"])

Sentry event ID: 236a2884253d442494773a23d0668fb6
Sentry is attempting to send 0 pending error messages
Waiting up to 2 seconds

I have ran ./mach browsertime --setup successfully before hand, so that should not be the issue,which I had to make a work around when setting it up by linking the zlip.h file with :

ln -s /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/zlib.h /usr/local/include/zlib.h

I'm on MacOS Catalina

Comment 1

[Greg Mierzwinski [:sparky]]

:kshampur, I think this was fixed by one of your recent patches?

Comment 2

[Kash Shampur [:kshampur] ⌚EST]

Yep! this should be resolved now by Bug 1754830