1699040 - Animation inspector's global play / pause buttons don't work until the rule panel has been finished loading

Status: VERIFIED FIXED

(DevTools :: Inspector: Animations, defect, P2)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:88.0) Gecko/20100101 Firefox/88.0 ID:20210312033752

As it looks like for a certain amount of time after loading a page the global pause button doesn't work. Clicking on it doesn't cause any animations to stop.

Steps:

1. Load https://www.esprit.de/herrenmode/bekleidung/pullover-strickjacken
2. Open the devtools inspector and select the animation pane
3. Click the global pause button

With step 3 the animations don't stop but continue to run. Trying again after a while might then work.

Maybe the amount of animations on that page causes a massive delay of the click event? It might be related to the slowdown as what I just filed as bug 1699039.

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Actually at some point the animations stop, and then I have the same problem again with clicking the play button.

Comment 2

[Daisuke Akatsuka (:daisuke)]

Attachment: slow.mp4

Thank you very much for filing the issue!

As the video I attached, it seems that it takes too much time to load the rule pane if launching the animation inspector with 3 pane view. And also while loading it, it seems that we can't click the pause button.
And bug 1699039 also may be related to the issue.

Comment 3

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1699040: Avoid rendering items that are out of displayed area.

Comment 4

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1699040: Change tests to adapt new changes.

Depends on D109845

Comment 5

[Daisuke Akatsuka (:daisuke)]

Attachment: Bug 1699040: Send properties as a part of status.

Depends on D109846

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2aac724081d8
Avoid rendering items that are out of displayed area. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/5df89206e867
Change tests to adapt new changes. r=jdescottes
https://hg.mozilla.org/integration/autoland/rev/67f1b9e425b9
Send properties as a part of status. r=jdescottes,devtools-backward-compat-reviewers

Comment 7

[Natalia Csoregi [:nataliaCs]]

https://hg.mozilla.org/mozilla-central/rev/2aac724081d8
https://hg.mozilla.org/mozilla-central/rev/5df89206e867
https://hg.mozilla.org/mozilla-central/rev/67f1b9e425b9

Comment 9

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Thanks! This works fine now with Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:89.0) Gecko/20100101 Firefox/89.0 ID:20210329214331.

Comment 10

[Daisuke Akatsuka (:daisuke)]

I’m glad to hear that!
Thank you very much for letting me know!