1699106 - Room loses focus when it changes type

Status: RESOLVED FIXED

(Chat Core :: Matrix, defect)

Description

[Martin Giger [:freaktechnik]]

When a room switches between being a direct messaging conversation and a MUC room, it will lose focus if it was currently selected. We should preserve the selection.

Comment 1

[Martin Giger [:freaktechnik]]

Attachment: Bug 1699106 - Support changing type of prplIConversation. r=clokep

Comment 2

[Martin Giger [:freaktechnik]]

Attachment: Bug 1699106 - Make Matrix conversation implementation androgynous to allow switching type seamlessly. r=clokep

Depends on D115532

Comment 3

[Martin Giger [:freaktechnik]]

Attachment: Bug 1699106 - Update tests for room type changing. r=clokep

Also adds some helpers that stub the matrix-sdk client instead of the actual protocol object instances. I think this should be a better long-term approach to tests.

Depends on D115533

Comment 4

[Patrick Cloke [:clokep]]

Could you add a brief description of the change across those three files? I think I get what's going on but a bit more context would help with the review!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/093a140f3372
Support changing type of prplIConversation. r=clokep
https://hg.mozilla.org/comm-central/rev/6986094bb695
Make Matrix conversation implementation androgynous to allow switching type seamlessly. r=clokep
https://hg.mozilla.org/comm-central/rev/d08927fa8149
Update tests for room type changing. r=clokep