1699107 - Handle room version changes

Status: RESOLVED FIXED

(Chat Core :: Matrix, enhancement)

Description

[Martin Giger [:freaktechnik]]

We need to handle room version changes. Not sure what our UI would look like, if we would have any. Maybe we just blindly follow the change and re-use the same conversation in the front-end?

Comment 1

[Magnus Melin [:mkmelin]]

What is a room version?

Comment 2

[Martin Giger [:freaktechnik]]

Room versions are essentially the spec version a room follows. A room version change means that on the protocol level a new room is created (with a different room version), though the user-visible alias etc. will stay the same.

The way element handles this is to show you a button to go to the new room instead of the chat input if the room version was upgraded.
I just noticed that the spec had something to say on client behaviors for room version upgrades: https://spec.matrix.org/unstable/client-server-api/#client-behaviour-27

The different room versions are specified at https://spec.matrix.org/unstable/rooms/. The differences are usually in how events are handled and the rules for event interactions. This is mostly handled by the SDK for us.

Comment 3

[Patrick Cloke [:clokep]]

(In reply to Martin Giger [:freaktechnik] from comment #0)

Maybe we just blindly follow the change and re-use the same conversation in the front-end?

I think this would be my preference. It does mean joining a room / accepting an invite for the user automatically, but I think that's OK?

Comment 4

[Martin Giger [:freaktechnik]]

(In reply to Patrick Cloke [:clokep] from comment #3)

(In reply to Martin Giger [:freaktechnik] from comment #0)

Maybe we just blindly follow the change and re-use the same conversation in the front-end?

I think this would be my preference. It does mean joining a room / accepting an invite for the user automatically, but I think that's OK?

Yeah, especially since the old room is just a read-only relic of the state before the version change (in theory). Based on the spec text I think even the spec agrees that would be ok.

Comment 5

[Martin Giger [:freaktechnik]]

Attachment: Bug 1699107 - Follow room version changes. r=clokep

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/comm-central/rev/6153c5b280ce
Follow room version changes. r=clokep