glean.ts and maker.ts should not use internal metric classes (e.g. CounterMetric)
Categories
(Data Platform and Tools Graveyard :: Glean.js, enhancement, P4)
Tracking
(Not tracked)
People
(Reporter: Dexter, Unassigned)
Details
(Whiteboard: [telemetry:glean-js:backlog])
Both glean.ts and maker.ts are currently using CounterMetric and DatetimeMetric to read stored data instead of relying on privately exposed, undispatched methods on CounterMetricType and DatetimeMetricType
Updated•3 years ago
|
Updated•3 years ago
|
Comment 1•3 years ago
|
||
Hi, is this bug still valid? If so, I would like to help but would need a bit more context. Thanks!
Comment 2•3 years ago
|
||
Hey Chin-Ying Li. Thanks for the interesting in taking this bug, I am not sure this is still valid. To be honest, I don't see how it would be better in the cases were we use the internal metric classes in glean.ts and maker.ts to use something else.
I will leave this open until Alessio returns so he can maybe clarify the intent here, but otherwise let's leave this one for now.
How do you feel about taking https://bugzilla.mozilla.org/show_bug.cgi?id=1712914 or, if you want something a bit more challenging, https://bugzilla.mozilla.org/show_bug.cgi?id=1716956 ?
Comment 3•3 years ago
|
||
Undispatched methods have been introduced a while back.
Updated•3 years ago
|
Description
•