1699221 - Make "segmented style toolbarbuttons" look good on Big Sur

Status: RESOLVED FIXED

(Core :: Widget: Cocoa, defect, P2)

Description

[Markus Stange [:mstange]]

We use segmented style toolbarbuttons in the page info window and for the toolbarbuttons in the library window.

On macOS 10.15 and below, these buttons look acceptable.
On macOS 11, they look foreign; we currently draw an opaque fill for these buttons which looks similar to what the buttons rendered natively on macOS 10.15, but it's out of place on macOS 11.

On macOS 11, native toolbarbuttons have no border and have different degrees of semi-transparent gray fills when they're hovered, pressed or checked. We should adopt this style on macOS 11.
We also need to special-case the text color of the selected button for macOS 11: On macOS 10.15 and below, for toolbarbuttons with text (seen e.g. in the page info window), the text on a selected toolbarbutton needs to be white because the button background is dark. On macOS 11, the background is much lighter and the text needs to be black to ensure sufficient contrast.

Comment 1

[Markus Stange [:mstange]]

Attachment: Bug 1699221 - Stop drawing opaque button shapes behind toolbar buttons on Big Sur. r=#mac-reviewers

This was only needed when we were drawing a 10.9-style toolbar gradient. With a
native toolbar appearance, the default drawing looks better.

Comment 2

[Harry Twyford]

One of the patches in bug 1698763 is similar to the patch in this bug. It should fix this issue, although there's still more work to be done to get toolbar buttons looking more like Big Sur-styled buttons.

EDIT: To be clear, I think we can close this bug after bug 1698763 lands. Styling toolbar buttons like Big Sur buttons is a separate issue.