Use proton accent colour for buttons/inputs in dark theme
Categories
(Firefox :: General, enhancement, P2)
Tracking
()
Tracking | Status | |
---|---|---|
firefox89 | --- | fixed |
People
(Reporter: mstriemer, Assigned: mstriemer)
References
(Blocks 2 open bugs, Regressed 3 open bugs)
Details
(Whiteboard: [proton-foundations])
Attachments
(1 file)
The accent colour for the proton dark theme (or in this case prefers-color-scheme:dark) should be a teal colour. Primary buttons, checkboxes, radios, and toggles should be updated to match the spec.
Updated•3 years ago
|
Assignee | ||
Updated•3 years ago
|
Assignee | ||
Comment 1•3 years ago
|
||
This also fixes up various about pages.
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/50cc5db86f1e Use proton dark theme in-content r=jaws
Pushed by ntim.bugs@gmail.com: https://hg.mozilla.org/integration/autoland/rev/421e6e333309 Use proton dark theme in-content r=jaws
Comment 4•3 years ago
|
||
Backed out changeset 421e6e333309 (bug 1699250) for browser_html_discover_view_clientid.js mochitest failures.
Backout link: https://hg.mozilla.org/integration/autoland/rev/11d175852847de48d0773d4ac1a2e0477967a8bd
Failure log: https://treeherder.mozilla.org/logviewer?job_id=334673071&repo=autoland&lineNumber=6651
[task 2021-03-28T00:13:54.729Z] 00:13:54 INFO - TEST-START | toolkit/mozapps/extensions/test/browser/browser_html_discover_view_clientid.js
[task 2021-03-28T00:13:55.155Z] 00:13:55 INFO - GECKO(8259) | Manager window unload handler
[task 2021-03-28T00:13:55.196Z] 00:13:55 INFO - GECKO(8259) | JavaScript error: resource://gre/actors/BrowserElementParent.jsm, line 24: TypeError: can't access property "ownerGlobal", browser is null
[task 2021-03-28T00:13:55.499Z] 00:13:55 INFO - GECKO(8259) | Manager window unload handler
[task 2021-03-28T00:13:55.514Z] 00:13:55 INFO - GECKO(8259) | JavaScript error: resource://gre/actors/BrowserElementParent.jsm, line 24: TypeError: can't access property "ownerGlobal", browser is null
[task 2021-03-28T00:13:56.276Z] 00:13:56 INFO - GECKO(8259) | Manager window unload handler
[task 2021-03-28T00:13:56.298Z] 00:13:56 INFO - GECKO(8259) | JavaScript error: resource://gre/actors/BrowserElementParent.jsm, line 24: TypeError: can't access property "ownerGlobal", browser is null
[task 2021-03-28T00:13:56.354Z] 00:13:56 INFO - GECKO(8259) | JavaScript error: , line 0: AbortError: Actor 'AboutPrivateBrowsing' destroyed before query 'ShouldShowSearch' was resolved
[task 2021-03-28T00:13:56.354Z] 00:13:56 INFO - GECKO(8259) | JavaScript error: , line 0: AbortError: Actor 'AboutPrivateBrowsing' destroyed before query 'ShouldShowSearchBanner' was resolved
[task 2021-03-28T00:13:56.355Z] 00:13:56 INFO - GECKO(8259) | JavaScript error: , line 0: AbortError: Actor 'AboutPrivateBrowsing' destroyed before query 'ShouldShowVPNPromo' was resolved
[task 2021-03-28T00:13:56.381Z] 00:13:56 INFO - GECKO(8259) | JavaScript error: resource:///actors/ContentSearchParent.jsm, line 624: TypeError: can't access property "addEventListener", browser is null
[task 2021-03-28T00:13:56.725Z] 00:13:56 INFO - GECKO(8259) | Manager window unload handler
[task 2021-03-28T00:13:56.733Z] 00:13:56 INFO - GECKO(8259) | JavaScript error: resource://gre/actors/BrowserElementParent.jsm, line 24: TypeError: can't access property "ownerGlobal", browser is null
[task 2021-03-28T00:13:57.044Z] 00:13:57 INFO - GECKO(8259) | Manager window unload handler
[task 2021-03-28T00:13:57.064Z] 00:13:57 INFO - GECKO(8259) | JavaScript error: resource://gre/actors/BrowserElementParent.jsm, line 24: TypeError: can't access property "ownerGlobal", browser is null
[task 2021-03-28T00:13:57.120Z] 00:13:57 INFO - GECKO(8259) | MEMORY STAT | vsize 3785MB | residentFast 808MB | heapAllocated 429MB
[task 2021-03-28T00:13:57.122Z] 00:13:57 INFO - TEST-OK | toolkit/mozapps/extensions/test/browser/browser_html_discover_view_clientid.js | took 2385ms
[task 2021-03-28T00:13:57.123Z] 00:13:57 INFO - TEST-INFO | started process screentopng
[task 2021-03-28T00:13:57.485Z] 00:13:57 INFO - TEST-INFO | screentopng: exit 0
[task 2021-03-28T00:13:57.485Z] 00:13:57 INFO - TEST-UNEXPECTED-FAIL | toolkit/mozapps/extensions/test/browser/browser_html_discover_view_clientid.js | Found an unexpected tab at the end of test run: http://localhost:33252/sumo/personalized-addons -
[task 2021-03-28T00:13:57.485Z] 00:13:57 INFO - checking window state
Assignee | ||
Updated•3 years ago
|
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/ae3a0e6dde00 Use proton dark theme in-content r=jaws
Comment 6•3 years ago
|
||
Backed out for causing failures on test_bug509732.xhtml.
Backout link: https://hg.mozilla.org/integration/autoland/rev/3222c39fb7299cce346739e5b04a58a8c75e922a
Failure log: https://treeherder.mozilla.org/logviewer?job_id=334698419&repo=autoland&lineNumber=3751
Pushed by mstriemer@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/d8d407400667 Use proton dark theme in-content r=jaws
Comment 8•3 years ago
|
||
bugherder |
Description
•