1699277 - Remove JSID_IS_ATOM from js/src/gc/AtomMarking.cpp

Status: RESOLVED FIXED

(Core :: JavaScript Engine, enhancement, P5)

Description

[Matthew Gaudet (he/him) [:mgaudet]]

+++ This bug was initially created as a clone of Bug #1699273 +++

Note: this bug is currently reserved for Outreachy applicants for the Spring/Summer 2021 cycle. If it has not been completed by the end of the application cycle, we will open it up.

Background

The JSID_IS_ATOM calls reflect an old style of SpiderMonkey programming that we think we can start to get away from, internally to the engine.

This Bug

This bug is about removing uses of JSID_IS_ATOM within the js/src/gc/AtomMarking.cpp file. Instead of using JSID_IS_ATOM we should be using JS::PropertyKey::isAtom, which is actually how JSID_IS_ATOM is implemented.

Optional: If nearby code you’re changing you see JSID_TO_ATOM, we are also planning on changing those to JS::PropertyKey::toAtom

Prerequisites

Before getting started, you'll want to

• You Have a checkout of the Firefox source code
• Make sure you can build and test SpiderMonkey
• Read this walkthrough about how development works in Firefox

How you’ll know you’re done

• The use of JSID_IS_ATOM is removed
• SpiderMonkey builds
• The tests run successfully.

Getting Help

Feel free to leave comments on this bug for questions, or, if you have more synchronous questions about this bug, feel free to drop into the #spidermonkey channel on chat.mozilla.org.

Tips:

• Not sure if the code you've been editing is getting run? Insert a call to MOZ_CRASH, a macro which will crash when executed, and run the entire test suite with an optimized build (for speed). If you see crashes, you can then use a debug build to make sure it's crashing in your code!

Comment 1

[Lia]

Hello, I am Outreachy applicant and would like to work on this issue

Comment 2

[Lia]

Attachment: Bug 1699277 - JSID_IS_ATOM replaced with JS::PropertyKey::isAtom. r=sfink

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/563ea901a087
JSID_IS_ATOM replaced with JS::PropertyKey::isAtom. r=sfink

Comment 4

[Bogdan Tara[:bogdan_tara | bogdant]]

https://hg.mozilla.org/mozilla-central/rev/563ea901a087