Closed Bug 1699405 Opened 4 years ago Closed 3 years ago

[wpt-sync] Sync PR 28128 - Integrate COOP in PolicyContainer

Categories

(Core :: DOM: Core & HTML, task, P4)

task

Tracking

()

RESOLVED FIXED
90 Branch
Tracking Status
firefox90 --- fixed

People

(Reporter: wpt-sync, Unassigned)

References

()

Details

(Whiteboard: [wptsync downstream])

Sync web-platform-tests PR 28128 into mozilla-central (this bug is closed when the sync is complete).

PR: https://github.com/web-platform-tests/wpt/pull/28128
Details from upstream follow.

b'P\xc3\xa2ris MEULEMAN <pmeuleman@chromium.org>' wrote:

Integrate COOP in PolicyContainer

This adds Cross-Origin Opener Policy to the policy container.
This was previously within [1], which was then split into COOP and COEP
specific CLs.
With this COOP inheritance is handled by the PolicyContainer.
PolicyContainer does not handle the inheritance from the opener during
a new window creation, given that COOP inheritance differs significantly:

  • It inherits from the top frame of the opener, if the opener is
    same-origin with its top frame.
    Further details in [2].

[1] https://chromium-review.googlesource.com/c/chromium/src/+/2490046/.
[2] https://docs.google.com/document/d/1CnG8IWCXencWxmsQMDt9JHUucfpbWXjgknRjquzquV0/edit#

Bug: 1153648
Change-Id: I77bb56bb0d6cd5c8f1523c14487817e970cb0bd2
Reviewed-on: https://chromium-review.googlesource.com/2565243
WPT-Export-Revision: 5996a949740c92d09486e85be3c9b47698046edb

PR 28128 applied with additional changes from upstream: c4f759fb1e985552c9d2891d641e9e2bf3f65e83
Component: web-platform-tests → DOM: Core & HTML
Product: Testing → Core

CI Results

Ran 14 Firefox configurations based on mozilla-central, and Firefox, Chrome, and Safari on GitHub CI

Total 3 tests and 3 subtests

Status Summary

Firefox

OK : 2[Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-opt, Gecko-windows10-64-qr-opt] 3[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, GitHub]
PASS : 5
CRASH : 1
FAIL : 1[Gecko-windows10-64-opt, Gecko-windows10-64-qr-opt] 4[Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-linux1804-64-tsan-opt, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, GitHub]
TIMEOUT: 1

Chrome

OK : 2
PASS : 4
CRASH : 1
FAIL : 2

Safari

OK : 3
PASS : 4
FAIL : 5

Links

Gecko CI (Treeherder)
GitHub PR Head
GitHub PR Base

Details

Crashes

/html/cross-origin-opener-policy/navigate-top-to-aboutblank.https.html: CRASH [Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-qr-opt], OK [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, GitHub], TIMEOUT [Gecko-windows10-64-opt] linked bug:Bug 1697386

New Tests That Don't Pass

/html/cross-origin-opener-policy/navigate-to-aboutblank.https.html
Navigate to about:blank from iframe with opener.top COOP: |header(Cross-Origin-Opener-Policy,same-origin-allow-popups), iframe origin: https://web-platform.test:8443, openee COOP: |header(Cross-Origin-Opener-Policy,unsafe-none), openee origin: https://www1.web-platform.test:8443.: FAIL (Chrome: FAIL, Safari: FAIL)
/html/cross-origin-opener-policy/navigate-top-to-aboutblank.https.html: CRASH [Gecko-linux1804-64-tsan-opt, Gecko-windows10-64-qr-opt], OK [Gecko-android-em-7.0-x86_64-debug-geckoview, Gecko-android-em-7.0-x86_64-opt-geckoview, Gecko-android-em-7.0-x86_64-qr-debug-geckoview, Gecko-android-em-7.0-x86_64-qr-opt-geckoview, Gecko-linux1804-64-debug, Gecko-linux1804-64-opt, Gecko-linux1804-64-qr-debug, Gecko-windows10-32-debug, Gecko-windows10-32-opt, Gecko-windows10-64-debug, Gecko-windows10-64-qr-debug, GitHub], TIMEOUT [Gecko-windows10-64-opt] (Chrome: CRASH, Safari: OK)
Navigate top to about:blank from iframe with opener COOP: |header(Cross-Origin-Opener-Policy,same-origin), iframe origin: https://web-platform.test:8443: FAIL (Safari: FAIL)
Navigate top to about:blank from iframe with opener COOP: |header(Cross-Origin-Opener-Policy,same-origin), iframe origin: https://www1.web-platform.test:8443: FAIL (Safari: FAIL)
Navigate top to about:blank from iframe with opener COOP: |header(Cross-Origin-Opener-Policy,same-origin-allow-popups), iframe origin: https://www1.web-platform.test:8443: FAIL (Safari: FAIL)

Pushed by wptsync@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/358e1f87750b [wpt PR 28128] - Integrate COOP in PolicyContainer, a=testonly https://hg.mozilla.org/integration/autoland/rev/80be590bba52 [wpt PR 28128] - Update wpt metadata, a=testonly
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → 90 Branch
You need to log in before you can comment on or make changes to this bug.