1699419 - Consolidate how window background is set

Status: RESOLVED WONTFIX

(Firefox :: Theme, task, P3)

Description

[Tim Nguyen :ntim]

Since proton is going to make Windows/macOS look the same, it's worth looking at consolidating the window/tabbar background is set:

• Windows 10 sets it on :root
  https://searchfox.org/mozilla-central/rev/f07a609a76136ef779c65185165ff5ac513cc172/browser/themes/windows/browser-aero.css#47-77

• Linux/Windows aero basic/Windows 7 or 8 use the native titlebar and don't set any background

• macOS also sets it on #navigator-toolbox (since bug 1694526)

• :-moz-lwtheme sets it on #navigator-toolbox (pretty recent change since bug 1594132)

Worth investigating if the more simple design of proton can allow this to be set from one single place.

Comment 1

[Molly Howell (she/her) (no longer active)]

Attachment: Bug 1699419 - Consolidate browser toolbar background handling. r=ntim

This patch moves code that sets the background of the browser toolbars into
one place. It also removes some non-Proton Windows-only code rather than
updating it for this, along with some other Windows-only code that doesn't seem
to ever go into effect.

Comment 2

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/0cf557aafeaa
Consolidate browser toolbar background handling. r=desktop-theme-reviewers,harry

Comment 3

[Marian-Vasile Laza]

https://hg.mozilla.org/mozilla-central/rev/0cf557aafeaa

Comment 4

[Harry Twyford]

This was backed out in bug 1719592. I don't think it's possible to consolidate window background setting across platforms. While MR1 removed many platform-specific styles, window/titlebar handling is still quite platform-dependent and mostly handled by widget code. We're not actually setting that many window background rules. On Linux, we set none to support the widest array of system themes. On Windows, we now usually set none as well. The titlebar color is the system titlebar color. comment 0 links to a block of rules for Windows 10, but those are now behind a !proton block and will be removed soon. With that said, we still have a fair number of custom rules on Windows related to titlebars because of varied Windows settings and versions. For instance, we still support putting the accent color in the titlebar in Windows HCM. Those rules can't be consolidated. On Mac, we set #f0f0f4 as a background color for the toolbox. This is because Mac apps usually have a single color in the title/toolbar. We want a two-toned look to match Firefox branding on Windows. This is also not something that can be used on other platforms because it would be painted over the platform's native look.